LayoutTests/fast/multicol/span/sole-spanner-inside-div.html - Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/multicol/span/sole-spanner-inside-div.html

Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase master Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff |

« LayoutTests/fast/multicol/span/pseudo-before-after-in-content.html ('K') | « LayoutTests/fast/multicol/span/sole-spanner-expected.html ('k') | LayoutTests/fast/multicol/span/sole-spanner-inside-div-expected.html » ('j') | Source/core/rendering/RenderBlockFlow.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <p>You should see the word 'PASS' on a green background below</p>

	3 <div style="-webkit-columns:10; -webkit-column-gap:0; -webkit-column-rule:1px so lid red; width:5em; background:green;">
	Julien - ping for review 2014/11/17 23:47:11 Let's avoid red for non failure (which matches the Let's avoid red for non failure (which matches the CSS Test policy). mstensho (USE GERRIT) 2014/11/18 13:29:26 But no rules should be drawn, so red would mean fa Show quoted text On 2014/11/17 23:47:11, Julien Chaffraix - PST wrote: > Let's avoid red for non failure (which matches the CSS Test policy). But no rules should be drawn, so red would mean failure here. I updated the pass condition instead. Julien - ping for review 2014/11/19 17:54:34 Is this really what the test checks or just piggy- Show quoted text On 2014/11/18 at 13:29:26, mstensho wrote: > On 2014/11/17 23:47:11, Julien Chaffraix - PST wrote: > > Let's avoid red for non failure (which matches the CSS Test policy). > > But no rules should be drawn, so red would mean failure here. I updated the pass condition instead. Is this really what the test checks or just piggy-backing on it to do more testing? mstensho (USE GERRIT) 2014/11/21 15:39:24 I think it belongs here. If column-span:all fails, Show quoted text On 2014/11/19 17:54:34, Julien Chaffraix - PST wrote: > On 2014/11/18 at 13:29:26, mstensho wrote: > > On 2014/11/17 23:47:11, Julien Chaffraix - PST wrote: > > > Let's avoid red for non failure (which matches the CSS Test policy). > > > > But no rules should be drawn, so red would mean failure here. I updated the > pass condition instead. > > Is this really what the test checks or just piggy-backing on it to do more > testing? I think it belongs here. If column-span:all fails, you end up with two lines as regular column content, and the column balancer should make the multicol container tall enough to contain one line, and you'd get two columns and a red rule between them.
	4 <div>

	5 <div style="-webkit-column-span:all;">PASS<br> </div>

	6 </div>

	7 </div>

OLD	NEW