Side by Side Diff: LayoutTests/fast/multicol/span/sole-spanner-inside-div.html
Issue 712553003:
[New Multicolumn] Actual support for layout of column-span:all. (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: rebase master
Created 6 years, 1 month ago
Use n/p to move between diff chunks;
N/P to move between comments.
Draft comments are only viewable by you.
On 2014/11/18 at 13:29:26, mstensho wrote:
> On 2014/11/17 23:47:11, Julien Chaffraix - PST wrote:
> > Let's avoid red for non failure (which matches the CSS Test policy).
>
> But no rules should be drawn, so red would mean failure here. I updated the
pass condition instead.
Is this really what the test checks or just piggy-backing on it to do more
testing?
mstensho (USE GERRIT)
2014/11/21 15:39:24
I think it belongs here. If column-span:all fails,
On 2014/11/19 17:54:34, Julien Chaffraix - PST wrote:
> On 2014/11/18 at 13:29:26, mstensho wrote:
> > On 2014/11/17 23:47:11, Julien Chaffraix - PST wrote:
> > > Let's avoid red for non failure (which matches the CSS Test policy).
> >
> > But no rules should be drawn, so red would mean failure here. I updated the
> pass condition instead.
>
> Is this really what the test checks or just piggy-backing on it to do more
> testing?
I think it belongs here. If column-span:all fails, you end up with two lines as
regular column content, and the column balancer should make the multicol
container tall enough to contain one line, and you'd get two columns and a red
rule between them.
Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all.
(Closed)
Created 6 years, 1 month ago by mstensho (USE GERRIT)
Modified 6 years ago
Reviewers: Julien - ping for review
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 86