LayoutTests/fast/multicol/span/pseudo-before-after-in-content.html - Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all.

Side by Side Diff: LayoutTests/fast/multicol/span/pseudo-before-after-in-content.html

Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: rebase master Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/multicol/span/fill-after-spanner-extra-height.html ('K') | « LayoutTests/fast/multicol/span/pseudo-before-after-expected.html ('k') | LayoutTests/fast/multicol/span/pseudo-before-after-in-content-expected.html » ('j') | LayoutTests/fast/multicol/span/sole-spanner-inside-div.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 #elm::before, #elm::after { display:block; -webkit-column-span:all; backgrou nd:yellow; content:".........."; }

	4 </style>

	5 <p>There should be five rectangles with identical sizes below. The first, third and fifth

	6 one should be blue with nothing inside. The second and fourth one should be yellow with some

	7 dots inside.</p>

	8 <div style="-webkit-columns:4; orphans:1; widows:1; line-height:100px; backgroun d:blue;">
	Julien - ping for review 2014/11/17 23:47:11 It seems like the orphans and widows properties ar It seems like the orphans and widows properties are not used in this use case as you're using anonymous blocks to split the paragraphs. I wouldn't be surprised if this applied to other tests. mstensho (USE GERRIT) 2014/11/18 13:29:26 orphans and widows are inherited by default, so th Show quoted text On 2014/11/17 23:47:11, Julien Chaffraix - PST wrote: > It seems like the orphans and widows properties are not used in this use case as > you're using anonymous blocks to split the paragraphs. I wouldn't be surprised > if this applied to other tests. orphans and widows are inherited by default, so this is no concern. Julien - ping for review 2014/11/19 17:54:33 I don't think I understand what you're saying here Show quoted text On 2014/11/18 13:29:26, mstensho wrote: > On 2014/11/17 23:47:11, Julien Chaffraix - PST wrote: > > It seems like the orphans and widows properties are not used in this use case > as > > you're using anonymous blocks to split the paragraphs. I wouldn't be surprised > > if this applied to other tests. > > orphans and widows are inherited by default, so this is no concern. I don't think I understand what you're saying here. Unneeded properties distract the readers from what the test is actually testing. If we don't need these properties, they should be removed. mstensho (USE GERRIT) 2014/11/21 15:39:24 No, I misunderstood YOU. :) We have discussed thi Show quoted text On 2014/11/19 17:54:33, Julien Chaffraix - PST wrote: > On 2014/11/18 13:29:26, mstensho wrote: > > On 2014/11/17 23:47:11, Julien Chaffraix - PST wrote: > > > It seems like the orphans and widows properties are not used in this use > case > > as > > > you're using anonymous blocks to split the paragraphs. I wouldn't be > surprised > > > if this applied to other tests. > > > > orphans and widows are inherited by default, so this is no concern. > > I don't think I understand what you're saying here. Unneeded properties distract > the readers from what the test is actually testing. If we don't need these > properties, they should be removed. No, I misunderstood YOU. :) We have discussed this one at some point earlier. If Blink had implemented orphans and widows according to the spec (initial value should be 2, according to the spec, but Blink doesn't do that), it's typically desirable to set them to 1 to allow breaking between lines anywhere (unless you want to test the orphans/widows implementation). But you're right: in this test they are unneeded, no matter how correctly they are implemented. I'll remove them. Done.
	9

	10 <span id="elm"> </span>

	11

	12 </div>

OLD	NEW