Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: Source/core/rendering/LayoutState.cpp

Issue 712553003: [New Multicolumn] Actual support for layout of column-span:all. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Code review. Camelize. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
11 * documentation and/or other materials provided with the distribution. 11 * documentation and/or other materials provided with the distribution.
12 * 12 *
13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY 13 * THIS SOFTWARE IS PROVIDED BY APPLE INC. ``AS IS'' AND ANY
14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE 14 * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR 15 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR 16 * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR
17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, 17 * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, 18 * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR 19 * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY 20 * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 21 * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 22 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 23 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
24 */ 24 */
25 25
26 #include "config.h" 26 #include "config.h"
27 #include "core/rendering/LayoutState.h" 27 #include "core/rendering/LayoutState.h"
28 28
29 #include "core/rendering/RenderFlowThread.h"
29 #include "core/rendering/RenderInline.h" 30 #include "core/rendering/RenderInline.h"
30 #include "core/rendering/RenderLayer.h" 31 #include "core/rendering/RenderLayer.h"
31 #include "core/rendering/RenderView.h" 32 #include "core/rendering/RenderView.h"
32 #include "platform/Partitions.h" 33 #include "platform/Partitions.h"
33 34
34 namespace blink { 35 namespace blink {
35 36
36 LayoutState::LayoutState(LayoutUnit pageLogicalHeight, bool pageLogicalHeightCha nged, RenderView& view) 37 LayoutState::LayoutState(LayoutUnit pageLogicalHeight, bool pageLogicalHeightCha nged, RenderView& view)
37 : m_isPaginated(pageLogicalHeight) 38 : m_isPaginated(pageLogicalHeight)
38 , m_pageLogicalHeightChanged(pageLogicalHeightChanged) 39 , m_pageLogicalHeightChanged(pageLogicalHeightChanged)
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 // If we don't establish a new page height, then propagate the old page height and offset down. 82 // If we don't establish a new page height, then propagate the old page height and offset down.
82 m_pageLogicalHeight = m_next->m_pageLogicalHeight; 83 m_pageLogicalHeight = m_next->m_pageLogicalHeight;
83 m_pageLogicalHeightChanged = m_next->m_pageLogicalHeightChanged; 84 m_pageLogicalHeightChanged = m_next->m_pageLogicalHeightChanged;
84 m_pageOffset = m_next->m_pageOffset; 85 m_pageOffset = m_next->m_pageOffset;
85 86
86 // Disable pagination for objects we don't support. For now this include s overflow:scroll/auto, inline blocks and 87 // Disable pagination for objects we don't support. For now this include s overflow:scroll/auto, inline blocks and
87 // writing mode roots. 88 // writing mode roots.
88 if (renderer.isUnsplittableForPagination()) { 89 if (renderer.isUnsplittableForPagination()) {
89 m_pageLogicalHeight = 0; 90 m_pageLogicalHeight = 0;
90 m_isPaginated = false; 91 m_isPaginated = false;
92 } else if (RenderFlowThread* flowThread = renderer.flowThreadContainingB lock()) {
93 // FIXME: this won't do if/when we add support for nested fragmentat ion contexts (e.g. a
94 // multicol container inside something paginated). Note, though, tha t nested
95 // fragmentation is something that has never worked in the engine (n ot in the old
96 // multicol implementation either).
97 m_isPaginated = !flowThread->isInsideColumnSpanner(&renderer);
91 } else { 98 } else {
92 m_isPaginated = m_pageLogicalHeight || m_next->m_columnInfo || rende rer.flowThreadContainingBlock(); 99 m_isPaginated = m_pageLogicalHeight || m_next->m_columnInfo;
93 } 100 }
94 } 101 }
95 102
96 if (!m_columnInfo) 103 if (!m_columnInfo)
97 m_columnInfo = m_next->m_columnInfo; 104 m_columnInfo = m_next->m_columnInfo;
98 105
99 // FIXME: <http://bugs.webkit.org/show_bug.cgi?id=13443> Apply control clip if present. 106 // FIXME: <http://bugs.webkit.org/show_bug.cgi?id=13443> Apply control clip if present.
100 } 107 }
101 108
102 LayoutState::LayoutState(RenderObject& root) 109 LayoutState::LayoutState(RenderObject& root)
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 } 151 }
145 152
146 void LayoutState::addForcedColumnBreak(const RenderBox& child, const LayoutUnit& childLogicalOffset) 153 void LayoutState::addForcedColumnBreak(const RenderBox& child, const LayoutUnit& childLogicalOffset)
147 { 154 {
148 if (!m_columnInfo || m_columnInfo->columnHeight()) 155 if (!m_columnInfo || m_columnInfo->columnHeight())
149 return; 156 return;
150 m_columnInfo->addForcedBreak(pageLogicalOffset(child, childLogicalOffset)); 157 m_columnInfo->addForcedBreak(pageLogicalOffset(child, childLogicalOffset));
151 } 158 }
152 159
153 } // namespace blink 160 } // namespace blink
OLDNEW
« no previous file with comments | « LayoutTests/fast/multicol/span/with-border-expected.html ('k') | Source/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698