[New Multicolumn] Actual support for layout of column-span:all.

Source/core/rendering/RenderMultiColumnFlowThreadTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "core/rendering/RenderMultiColumnFlowThread.h"
 
 #include "core/rendering/RenderMultiColumnSet.h"
 #include "core/rendering/RenderMultiColumnSpannerSet.h"
@@ skipping 219 matching lines @@
     EXPECT_EQ(columnSetSignature(flowThread), "cscs");
     RenderMultiColumnSet* columnSet = flowThread->firstMultiColumnSet()->nextSiblingMultiColumnSet();
     EXPECT_EQ(flowThread->containingColumnSpannerSet(document().getElementById("spanner1")->renderer()), columnSet);
     EXPECT_EQ(toRenderMultiColumnSpannerSet(columnSet)->rendererInFlowThread(), document().getElementById("spanner1")->renderer());
     columnSet = columnSet->nextSiblingMultiColumnSet()->nextSiblingMultiColumnSet();
     EXPECT_EQ(flowThread->containingColumnSpannerSet(document().getElementById("spanner2")->renderer()), columnSet);
     EXPECT_EQ(toRenderMultiColumnSpannerSet(columnSet)->rendererInFlowThread(), document().getElementById("spanner2")->renderer());
     EXPECT_EQ(flowThread->containingColumnSpannerSet(document().getElementById("outer")->renderer()), nullptr);
 }
 
+TEST_F(MultiColumnRenderingTest, columnSetAtBlockOffset)
+{
+    setMulticolHTML("<div id='mc' style='line-height:100px;'>text<br>text<br>text<br>text<br>text<div id='spanner1'>spanner</div>text<br>text<div id='spanner2'>text<br>text</div>text</div>");
+    RenderMultiColumnFlowThread* flowThread = findFlowThread("mc");
+    EXPECT_EQ(columnSetSignature(flowThread), "cscsc");
+    RenderMultiColumnSet* firstRow = flowThread->firstMultiColumnSet();
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(-10000)), firstRow); // negative overflow
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit()), firstRow);
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(499)), firstRow); // bottom of last line in first row.
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(599)), firstRow); // empty content in last column in first row
+    RenderMultiColumnSet* firstSpanner = firstRow->nextSiblingMultiColumnSet();
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(600)), firstSpanner);
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(699)), firstSpanner);
+    RenderMultiColumnSet* secondRow = firstSpanner->nextSiblingMultiColumnSet();
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(700)), secondRow);
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(899)), secondRow);
+    RenderMultiColumnSet* secondSpanner = secondRow->nextSiblingMultiColumnSet();
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(900)), secondSpanner);
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(1099)), secondSpanner);
+    RenderMultiColumnSet* thirdRow = secondSpanner->nextSiblingMultiColumnSet();
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(1100)), thirdRow);
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(1199)), thirdRow); // bottom of last row
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(10000)), thirdRow); // overflow
+}
+
+TEST_F(MultiColumnRenderingTest, columnSetAtBlockOffset_verticalRl)
+{
+    setMulticolHTML("<div id='mc' style='line-height:100px; -webkit-writing-mode:vertical-rl;'>text<br>text<br>text<br>text<br>text<div id='spanner1'>spanner</div>text<br>text<div id='spanner2'>text<br>text</div>text</div>");
+    RenderMultiColumnFlowThread* flowThread = findFlowThread("mc");
+    EXPECT_EQ(columnSetSignature(flowThread), "cscsc");
+    RenderMultiColumnSet* firstRow = flowThread->firstMultiColumnSet();
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(-10000)), firstRow); // negative overflow
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit()), firstRow);
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(499)), firstRow); // bottom of last line in first row.
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(599)), firstRow); // empty content in last column in first row
+    RenderMultiColumnSet* firstSpanner = firstRow->nextSiblingMultiColumnSet();
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(600)), firstSpanner);
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(699)), firstSpanner);
+    RenderMultiColumnSet* secondRow = firstSpanner->nextSiblingMultiColumnSet();
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(700)), secondRow);
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(899)), secondRow);
+    RenderMultiColumnSet* secondSpanner = secondRow->nextSiblingMultiColumnSet();
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(900)), secondSpanner);
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(1099)), secondSpanner);
+    RenderMultiColumnSet* thirdRow = secondSpanner->nextSiblingMultiColumnSet();
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(1100)), thirdRow);
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(1199)), thirdRow); // bottom of last row
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(10000)), thirdRow); // overflow
+}
+
+TEST_F(MultiColumnRenderingTest, columnSetAtBlockOffset_verticalLr)

[Julien - ping for review, 2014/12/03 23:02:22]

The name is unconsistent, you should either useCamelCaseVariables or
use_underscored_variables but not both.

[mstensho (USE GERRIT), 2014/12/10 13:48:19]

Done.

+{
+    setMulticolHTML("<div id='mc' style='line-height:100px; -webkit-writing-mode:vertical-lr;'>text<br>text<br>text<br>text<br>text<div id='spanner1'>spanner</div>text<br>text<div id='spanner2'>text<br>text</div>text</div>");
+    RenderMultiColumnFlowThread* flowThread = findFlowThread("mc");
+    EXPECT_EQ(columnSetSignature(flowThread), "cscsc");
+    RenderMultiColumnSet* firstRow = flowThread->firstMultiColumnSet();
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(-10000)), firstRow); // negative overflow
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit()), firstRow);
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(499)), firstRow); // bottom of last line in first row.
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(599)), firstRow); // empty content in last column in first row
+    RenderMultiColumnSet* firstSpanner = firstRow->nextSiblingMultiColumnSet();
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(600)), firstSpanner);
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(699)), firstSpanner);
+    RenderMultiColumnSet* secondRow = firstSpanner->nextSiblingMultiColumnSet();
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(700)), secondRow);
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(899)), secondRow);
+    RenderMultiColumnSet* secondSpanner = secondRow->nextSiblingMultiColumnSet();
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(900)), secondSpanner);
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(1099)), secondSpanner);
+    RenderMultiColumnSet* thirdRow = secondSpanner->nextSiblingMultiColumnSet();
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(1100)), thirdRow);
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(1199)), thirdRow); // bottom of last row
+    EXPECT_EQ(flowThread->columnSetAtBlockOffset(LayoutUnit(10000)), thirdRow); // overflow
+}
+
 } // anonymous namespace
 
 } // namespace blink