Source/core/css/CSSCalculationValue.cpp - Issue 71253002: Eliminate "FractionConversion" from CSSPrimitiveValue::convertToLength

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSCalculationValue.cpp

Issue 71253002: Eliminate "FractionConversion" from CSSPrimitiveValue::convertToLength (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/CSSCalculationValue.cpp

diff --git a/Source/core/css/CSSCalculationValue.cpp b/Source/core/css/CSSCalculationValue.cpp

index c5ed81a78a696cdac73116385d1256f7ce15e69e..ceca978e3cca7bf3dc0ccfe78029b2dcbabba431 100644

--- a/Source/core/css/CSSCalculationValue.cpp

+++ b/Source/core/css/CSSCalculationValue.cpp

@@ -235,7 +235,7 @@ public:

case CalcPercentLength: {

CSSPrimitiveValue* primitiveValue = m_value.get();

return adoptPtr(new CalcExpressionLength(primitiveValue

- ? primitiveValue->convertToLength<FixedFloatConversion | PercentConversion | FractionConversion>(style, rootStyle, zoom)

+ ? primitiveValue->convertToLength<FixedFloatConversion | PercentConversion>(style, rootStyle, zoom)

: Length(Undefined)));

}

// Only types that could be part of a Length expression can be converted

« no previous file with comments | « no previous file | Source/core/css/CSSParser-in.cpp » ('j') | no next file with comments »