Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(17)

Issue 71253002: Eliminate "FractionConversion" from CSSPrimitiveValue::convertToLength (Closed)

Created:
6 years ago by Timothy Loh
Modified:
6 years ago
CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Eliminate "FractionConversion" from CSSPrimitiveValue::convertToLength The FractionConversion argument in CSSPrimitiveValue::convertToLength doesn't seem to actually have a purpose. It is for converting numbers into Length(x * 100, Percent), but this case shouldn't be reachable. The original patch introducing it[1] doesn't shed any light either. The only way I could find to get into this conversion was in the fast path for parsing transforms, where e.g. translate(0) would get the 0 parsed as a number and not a <length>. This patch fixes this parser error and removes the now unused FractionConversion argument. Note that we can probably also merge the two Fixed conversions, as the two only differ in clamping large numbers (probably unintended). [1] https://bugs.webkit.org/show_bug.cgi?id=74913 BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161991

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -12 lines) Patch
M Source/core/css/CSSCalculationValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSParser-in.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/resolver/FilterOperationResolver.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/TransformBuilder.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Timothy Loh
6 years ago (2013-11-13 07:25:06 UTC) #1
Julien - ping for review
I couldn't find how this code path could be reached either. Assuming this passes the ...
6 years ago (2013-11-14 03:54:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timloh@chromium.org/71253002/1
6 years ago (2013-11-14 03:55:08 UTC) #3
commit-bot: I haz the power
6 years ago (2013-11-14 05:43:41 UTC) #4
Message was sent while issue was closed.
Change committed as 161991

Powered by Google App Engine
This is Rietveld 408576698