Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: Source/WebCore/ChangeLog

Issue 7125002: Merge 87960 - 2011-06-02 Adrienne Walker <enne@google.com> (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/782/
Patch Set: Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/ChangeLog
===================================================================
--- Source/WebCore/ChangeLog (revision 88206)
+++ Source/WebCore/ChangeLog (working copy)
@@ -1,18 +1,1194 @@
-2011-06-05 Kent Tamura <tkent@chromium.org>
+2011-06-02 Adrienne Walker <enne@google.com>
+ Reviewed by James Robinson.
+
+ [chromium] Compositor HUD should respect mapTexSubImage2D returning NULL
+ https://bugs.webkit.org/show_bug.cgi?id=61954
+
+ * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
+ (WebCore::CCHeadsUpDisplay::draw):
+
+2011-06-02 Brady Eidson <beidson@apple.com>
+
+ Reviewed by Oliver Hunt.
+
+ <rdar://problem/9539920> and https://bugs.webkit.org/show_bug.cgi?id=61950
+ Repro crash loading certain webarchives after r87566.
+
+ Test: webarchive/loading/javascript-url-iframe-crash.html
+
+ * bindings/ScriptControllerBase.cpp:
+ (WebCore::ScriptController::executeIfJavaScriptURL): DocumentWriter::replaceDocument can
+ cause the DocumentLoader to be destroyed, so protect it with a Ref here.
+
+2011-06-02 Jay Civelli <jcivelli@chromium.org>
+
+ Reviewed by Adam Barth.
+
+ Adding MHTML generation support to MHTMLArchive.
+ https://bugs.webkit.org/show_bug.cgi?id=7169
+
+ * loader/archive/mhtml/MHTMLArchive.cpp:
+ (WebCore::generateRandomBoundary):
+ (WebCore::replaceNonPrintableCharacters):
+ (WebCore::MHTMLArchive::generateMHTMLData):
+ * loader/archive/mhtml/MHTMLArchive.h:
+ * page/PageSerializer.cpp:
+ (WebCore::PageSerializer::serializeFrame):
+ (WebCore::PageSerializer::serializeCSSStyleSheet):
+ * platform/SharedBuffer.cpp:
+ (WebCore::SharedBuffer::append):
+ * platform/SharedBuffer.h:
+
+2011-06-02 Simon Fraser <simon.fraser@apple.com>
+
+ Reviewed by Andreas Kling.
+
+ Share Path code that uses beziers to construct a rounded rect
+ https://bugs.webkit.org/show_bug.cgi?id=61960
+
+ Have two methods in Path that construct beziers for rounded
+ rects to share the same code.
+
+ Make gCircleControlPoint a little more precise, and add
+ a comment describing its derivation.
+
+ Make use of FloatRect::maxX() and maxY().
+
+ * platform/graphics/Path.cpp:
+ (WebCore::Path::addRoundedRect):
+ (WebCore::Path::addBeziersForRoundedRect):
+ * platform/graphics/Path.h:
+
+2011-06-02 Ryosuke Niwa <rniwa@webkit.org>
+
+ Reviewed by Enrica Casucci.
+
+ ApplyStyleCommand shouldn't call collapseTextDecorationProperties
+ https://bugs.webkit.org/show_bug.cgi?id=61887
+
+ Removed the call to collapseTextDecorationProperties in ApplyStyleCommand::applyInlineStyle.
+
+ No new tests because this is a code refactoring.
+
+ * editing/ApplyStyleCommand.cpp:
+ (WebCore::ApplyStyleCommand::applyInlineStyle): No loner calls collapseTextDecorationProperties.
+ (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): Updated comment.
+ * editing/EditingStyle.cpp:
+ (WebCore::HTMLElementEquivalent::propertyExistsInStyle): Added to check both text-decoration
+ and -webkit-text-decorations-in-effect.
+ (WebCore::HTMLTextDecorationEquivalent::HTMLTextDecorationEquivalent): Added a comment.
+ (WebCore::HTMLTextDecorationEquivalent::propertyExistsInStyle): Checks both text-decoration
+ and -webkit-text-decorations-in-effect.
+ (WebCore::HTMLTextDecorationEquivalent::valueIsPresentInStyle): Checks if a text decoration
+ is present in -webkit-text-decorations-in-effect or text-decoration preferring the former.
+ (WebCore::EditingStyle::conflictsWithInlineStyleOfElement): Merged loops for when conflictingProperties
+ is false and true. Added a support for -webkit-text-decorations-in-effect.
+
+2011-06-02 Ryosuke Niwa <rniwa@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ Make more functions static local in EventHandlers.cpp
+ https://bugs.webkit.org/show_bug.cgi?id=58503
+
+ Removed canHandleDragAndDropForTarget and made focusDirectionForKey local to EventHandler.cpp.
+
+ * page/EventHandler.cpp:
+ (WebCore::targetIsFrame): Extracted from canHandleDragAndDropForTarget.
+ (WebCore::EventHandler::updateDragAndDrop): Calls contentFrameForTarget instead of canHandleDragAndDropForTarget.
+ (WebCore::EventHandler::cancelDragAndDrop): Ditto.
+ (WebCore::EventHandler::performDragAndDrop): Ditto.
+ (WebCore::focusDirectionForKey): No longer a member function of EventHandler class.
+ (WebCore::handleKeyboardSelectionMovement): No longer a member function of EventHandler class; also calls
+ focusDirectionForKey instead of manually comparing.
+ * page/EventHandler.h:
+
+2011-06-02 Alok Priyadarshi <alokp@chromium.org>
+
+ Reviewed by James Robinson.
+
+ [chromium] Things jump around when selecting anything on the page
+ https://bugs.webkit.org/show_bug.cgi?id=61639
+
+ WebCore::LayerTextureUpdaterSkPicture::updateTextureRect was not updating a tile sub-region properly.
+ It did not consider dest-rect when selecting the clip and translation required to draw the content-rect into dest-rect.
+ Also removed clearing of framebuffer because it used to clear the whole tile not just dest-rect.
+ An appropriate viewport could be set to just clear the dest-rect, but it was debug only code and I did not want to mess
+ with the viewport set by skia.
+
+ No new tests. This case should be covered by most of the layout tests (pixel) targeting selection or hovering when chromium is run in compositing mode.
+ Here is a non-exhaustive list of existing tests covering this case.
+ Test: editing/selection/14971.html (existing)
+ editing/selection/3690703-2.html (existing)
+ editing/selection/4402375.html (existing)
+ editing/selection/4818145.html (existing)
+
+ * platform/graphics/chromium/LayerTextureUpdaterCanvas.cpp:
+ (WebCore::LayerTextureUpdaterSkPicture::updateTextureRect):
+ (WebCore::LayerTextureUpdaterSkPicture::createFrameBuffer):
+ * platform/graphics/chromium/LayerTextureUpdaterCanvas.h:
+
+2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Add build logistics and plumbing for window.internals object.
+ https://bugs.webkit.org/show_bug.cgi?id=60313
+
+ Test: fast/harness/internals-object.html
+
+ * Configurations/WebCoreTestSupport.xcconfig: Added.
+ * DerivedSources.make: Added support for generating from Internals.idl.
+ * WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
+ * WebCore.gypi: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
+ * testing/Internals.cpp: Added.
+ * testing/Internals.h: Added.
+ * testing/Internals.idl: Added.
+ * testing/js/WebCoreTestSupport.cpp: Added.
+ * testing/js/WebCoreTestSupport.h: Added.
+ * testing/v8/WebCoreTestSupport.cpp: Added.
+ * testing/v8/WebCoreTestSupport.h: Added.
+
+2011-06-01 Adrienne Walker <enne@google.com>
+
+ Reviewed by Eric Seidel.
+
+ [chromium] LayerChromium should use a RefPtr for replica layer
+ https://bugs.webkit.org/show_bug.cgi?id=61898
+
+ Having this member variable be a raw pointer is brittle and assumes
+ that the GraphicsLayer tree keeps this in sync. There aren't any
+ known bugs caused by this, but it seems like good sense to do this.
+
+ * platform/graphics/chromium/LayerChromium.h:
+ (WebCore::LayerChromium::replicaLayer):
+
+2011-06-02 Ryosuke Niwa <rniwa@webkit.org>
+
+ Reviewed by Eric Seidel.
+
+ REGRESSION: inline style is lost when deleting line break between paragraphs with same style
+ https://bugs.webkit.org/show_bug.cgi?id=61899
+
+ The bug was caused by ReplaceSelectionCommand::doApply's calling handleStyleSpansBeforeInsertion
+ before insertionPos is adjusted by positionAvoidingPrecedingNodes and positionOutsideTabSpan.
+
+ Fixed the bug by calling handleStyleSpansBeforeInsertion after the calls to these two functions.
+
+ Test: editing/deleting/delete-line-break-between-paragraphs-with-same-style.html
+
+ * editing/ReplaceSelectionCommand.cpp:
+ (WebCore::ReplaceSelectionCommand::doApply):
+
+2011-06-01 Ryosuke Niwa <rniwa@webkit.org>
+
+ Reviewed by Simon Fraser.
+
+ REGRESSION: Text selection broken for text with line-height applied
+ https://bugs.webkit.org/show_bug.cgi?id=54929
+
+ The bug was caused by RenderText::positionForPoint's not considering the case where a point is
+ above selectionTop and below lineTop of the first root inline box. Fixed the bug by considering
+ any point between selectionTop and lineTop to be inside a root inline box. This condition is
+ consistent with the condition we use to determine the bottom of a line.
+
+ Test: editing/selection/hit-test-on-text-with-line-height.html
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::positionForPointWithInlineChildren): Fixed a condition to determine whether
+ or not a point is above the first root line box. We need to check both selectionTop and logicalTop
+ for the same reason explained above.
+ * rendering/RenderText.cpp:
+ (WebCore::RenderText::positionForPoint): See above.
+
+2011-06-02 Andreas Kling <kling@webkit.org>
+
+ Reviewed by James Robinson.
+
+ Canvas/V8: Fix setting strokeStyle or fillStyle to a CSS system color.
+ https://bugs.webkit.org/show_bug.cgi?id=61944
+
+ Call setFillColor/setStrokeColor (instead of setFillStyle/setStrokeStyle)
+ for string styles. This ensures that system color resolution is performed,
+ and matches what the JSC bindings do.
+
+ Test: canvas/philip/tests/2d.fillStyle.parse.system.html
+
+ * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
+ (WebCore::toCanvasStyle):
+ (WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorSetter):
+ (WebCore::V8CanvasRenderingContext2D::fillStyleAccessorSetter):
+
+2011-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
+
+ Unreviewed, rolling out r87920.
+ http://trac.webkit.org/changeset/87920
+ https://bugs.webkit.org/show_bug.cgi?id=61943
+
+ This patch does not build in Win Builder (dbg)(shared)
+ downstream (Requested by abarth|gardener on #webkit).
+
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupContainer::showPopup):
+ (WebCore::PopupListBox::handleMouseReleaseEvent):
+ (WebCore::PopupListBox::acceptIndex):
+
+2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Unreviewed, rolling out r87926.
+ http://trac.webkit.org/changeset/87926
+ https://bugs.webkit.org/show_bug.cgi?id=60313
+
+ Fails to find WebCoreTestSupport.dylib on bots.
+
+ * Configurations/WebCore.xcconfig:
+ * Configurations/WebCoreTestSupport.xcconfig: Removed.
+ * DerivedSources.make:
+ * WebCore.exp.in:
+ * WebCore.gyp/WebCore.gyp:
+ * WebCore.gypi:
+ * WebCore.xcodeproj/project.pbxproj:
+ * bindings/js/JSDOMWrapper.cpp:
+ (WebCore::JSDOMWrapper::~JSDOMWrapper):
+ * bindings/js/JSDOMWrapper.h:
+ * testing/Internals.cpp: Removed.
+ * testing/Internals.h: Removed.
+ * testing/Internals.idl: Removed.
+ * testing/js/WebCoreTestSupport.cpp: Removed.
+ * testing/js/WebCoreTestSupport.h: Removed.
+ * testing/v8/WebCoreTestSupport.cpp: Removed.
+ * testing/v8/WebCoreTestSupport.h: Removed.
+
+2011-06-02 Carlos Garcia Campos <cgarcia@igalia.com>
+
+ Reviewed by Martin Robinson.
+
+ [GTK] Implement popup menus in Webkit2
+ https://bugs.webkit.org/show_bug.cgi?id=61854
+
+ Move common code into a new class to be used by both WebKit1 and
+ WebKit2.
+
+ * GNUmakefile.list.am: Add new files to compilation.
+ * platform/gtk/GtkPopupMenu.cpp: Copied from Source/WebCore/platform/gtk/PopupMenuGtk.cpp.
+ (WebCore::GtkPopupMenu::GtkPopupMenu):
+ (WebCore::GtkPopupMenu::~GtkPopupMenu):
+ (WebCore::GtkPopupMenu::clear): Remove all menu items.
+ (WebCore::GtkPopupMenu::appendSeparator): Add a new separator
+ item to the menu.
+ (WebCore::GtkPopupMenu::appendItem): Add a new item to the menu for
+ the given action.
+ (WebCore::GtkPopupMenu::popUp): Show the menu.
+ (WebCore::GtkPopupMenu::popDown): Hide the menu.
+ (WebCore::GtkPopupMenu::menuRemoveItem):
+ (WebCore::GtkPopupMenu::menuPositionFunction):
+ (WebCore::GtkPopupMenu::resetTypeAheadFindState):
+ (WebCore::GtkPopupMenu::typeAheadFind):
+ (WebCore::GtkPopupMenu::selectItemCallback):
+ (WebCore::GtkPopupMenu::keyPressEventCallback):
+ * platform/gtk/GtkPopupMenu.h: Copied from Source/WebCore/platform/gtk/PopupMenuGtk.h.
+ (WebCore::GtkPopupMenu::create):
+ (WebCore::GtkPopupMenu::platformMenu):
+ * platform/gtk/PopupMenuGtk.cpp:
+ (WebCore::PopupMenuGtk::PopupMenuGtk):
+ (WebCore::PopupMenuGtk::~PopupMenuGtk):
+ (WebCore::PopupMenuGtk::show): Use GtkPopupMenu.
+ (WebCore::PopupMenuGtk::hide): Ditto.
+ (WebCore::PopupMenuGtk::menuItemActivated):
+ (WebCore::PopupMenuGtk::menuUnmapped):
+ * platform/gtk/PopupMenuGtk.h:
+
+2011-05-21 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Add build logistics and plumbing for window.internals object.
+ https://bugs.webkit.org/show_bug.cgi?id=60313
+
+ Test: fast/harness/internals-object.html
+
+ * Configurations/WebCoreTestSupport.xcconfig: Added.
+ * DerivedSources.make: Added support for generating from Internals.idl.
+ * WebCore.gyp/WebCore.gyp: Added new webcore_test_support library.
+ * WebCore.gypi: Ditto.
+ * WebCore.xcodeproj/project.pbxproj: Added WebCoreTestSupport library.
+ * testing/Internals.cpp: Added.
+ * testing/Internals.h: Added.
+ * testing/Internals.idl: Added.
+ * testing/js/WebCoreTestSupport.cpp: Added.
+ * testing/js/WebCoreTestSupport.h: Added.
+ * testing/v8/WebCoreTestSupport.cpp: Added.
+ * testing/v8/WebCoreTestSupport.h: Added.
+
+2011-06-02 Naoki Takano <takano.naoki@gmail.com>
+
Reviewed by Dimitri Glazkov.
- Rolling out r84528.
- http://trac.webkit.org/changeset/84528
- https://bugs.webkit.org/show_bug.cgi?id=62100
+ [Chromium] Click event is not fired for a menulist <select>
+ https://bugs.webkit.org/show_bug.cgi?id=60563
- It made several problems on elements with new shadow DOM.
+ Tests: SelectItemEventFire, SelectItemKeyEvent, SelectItemRemoveSelectOnChange and SelectItemRemoveSelectOnChange in webkit_unit_tests.
+ * platform/chromium/PopupMenuChromium.cpp:
+ (WebCore::PopupContainer::showPopup): Set m_focusedNode from m_frameView.
+ (WebCore::PopupListBox::handleMouseReleaseEvent): Call dispatchMouseEvent to forward the event only if select popup.
+ (WebCore::PopupListBox::acceptIndex): Change to return accepted or not.
+
+2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
+
+ Reviewed by Darin Adler.
+
+ Stop event propagation for cases where relatedTarget is both ancestor of the target and at shadow boundary.
+ https://bugs.webkit.org/show_bug.cgi?id=61892
+
+ In the cases where the relatedTarget of an event is an ancestor of the target, and the relatedTarget is
+ a shadow host, we should not allow events to escape out of the hosted shadow DOM subtree.
+
+ * dom/EventDispatcher.cpp:
+ (WebCore::EventDispatcher::adjustToShadowBoundaries): Added a check that is valid for both new and old shadow DOM.
+
+2011-06-02 Hans Wennborg <hans@chromium.org>
+
+ Reviewed by Tony Gentilcore.
+
+ Fix LevelDBTransaction::clearTree()
+ https://bugs.webkit.org/show_bug.cgi?id=61917
+
+ This was broken in the code I copied it from; we can't delete and walk
+ the tree at the same time.
+
+ No new functionality, no new tests.
+
+ * platform/leveldb/LevelDBTransaction.cpp:
+ (WebCore::LevelDBTransaction::clearTree):
+
+2011-06-02 Andreas Kling <kling@webkit.org>
+
+ Rubber-stamped by Simon Hausmann.
+
+ Remove Qt's precompiled header hack as it was broken, and was not even
+ used unless building WebKit inside a Qt tree.
+
+ * WebCore.pri:
+
+2011-06-02 James Robinson <jamesr@chromium.org>
+
+ Reviewed by Brady Eidson.
+
+ DocumentLoader keeps a reference to all URL strings ever loaded leading to lots of memory waste
+ https://bugs.webkit.org/show_bug.cgi?id=61894
+
+ DocumentLoader::m_resourcesClientKnowsAbout is a set of all the URLs that have passed through
+ FrameLoader::dispatchWillSendRequest() and is used by FrameLoader::loadedResourceFromMemoryCached to decide
+ whether to inform the FrameLoader's m_client about this load. Unfortunately, this set holds a reference to the
+ URL string for every resource loaded, so on pages that use data URLs to "load" large amounts of data this leaks
+ lots of memory.
+
+ This set only has an effect on the Mac port, as the only two ports that implement
+ FrameLoaderClient::dispatchDidLoadResourceFromMemoryCache() are Chromium and Mac and the Chromium implementation
+ can correctly handle receiving multiple callbacks. This patch limits the set to only PLATFORM(MAC) so other
+ ports do not have to pay this memory cost. It's possible that a better fix exists specifically for the Mac port
+ implementation, but that would have to determined by someone who works on that port specifically.
+
+ * loader/DocumentLoader.h:
+ (WebCore::DocumentLoader::didTellClientAboutLoad):
+ (WebCore::DocumentLoader::haveToldClientAboutLoad):
+
+2011-06-02 Aparna Nandyal <aparna.nand@wipro.com>
+
+ Reviewed by Andreas Kling.
+
+ [Qt] Multiple drop events when doing DnD of images.
+ https://bugs.webkit.org/show_bug.cgi?id=61504
+
+ Duplicate entries of the url were getting added into drag data
+ which is removed. The duplicate entries were causing the same image
+ url to be copied twice. The code changes now match other webkit ports.
+
+ * platform/qt/ClipboardQt.cpp:
+ (WebCore::ClipboardQt::declareAndWriteDragImage):
+
+2011-06-02 Naiem Shaik <naiem.shaik@gmail.com>
+
+ Reviewed by Kent Tamura.
+
+ Fixing invalid value being returned for default checkbox and radio state
+ https://bugs.webkit.org/show_bug.cgi?id=61674
+
+ As per http://www.w3.org/TR/html5/number-state.html#checkbox-state and
+ http://www.w3.org/TR/html5/number-state.html#radio-button-state:
+ The value IDL attribute is in mode default/on:
+ If the element has a value attribute, it must return that attribute's
+ value; otherwise, it must return the string "on".
+ Currently default value is empty string;Default value of Radio button
+ and checkbox should be "on".Changed fallbackValue function to return the same
+ This works as per spec in IE9,Firefox and Opera
+
+ Tests: fast/forms/checkbox-default-value.html
+ fast/forms/radio-default-value.html
+
+ * html/BaseCheckableInputType.cpp:
+ (WebCore::BaseCheckableInputType::fallbackValue):
+
+2011-06-02 Kent Tamura <tkent@chromium.org>
+
+ [Chromium/Mac] Fix a wrong merge for r87881
+ https://bugs.webkit.org/show_bug.cgi?id=61845
+
+ * platform/chromium/ThemeChromiumMac.mm:
+ (WebCore::paintStepper):
+
+2011-06-02 Ian Henderson <ianh@apple.com>
+
+ Reviewed by Simon Fraser.
+
+ [CG] GraphicsContext::fillRoundedRect() ignores the gradient fill the CGContextFillEllipseInRect() code path
+ https://bugs.webkit.org/show_bug.cgi?id=61882
+
+ If we have a gradient or pattern fill set, take the slow path, which
+ handles these cases properly.
+
+ No new tests, since we never try to fill a rounded rect with a
+ gradient or pattern.
+
+ * platform/graphics/cg/GraphicsContextCG.cpp:
+ (WebCore::GraphicsContext::fillRoundedRect):
+
+2011-06-02 MORITA Hajime <morrita@google.com>
+
+ Reviewed by Kent Tamura.
+
+ [Refactoring] Node::nextRenderer() and previousRenderer() should be part of NodeRenderingContext
+ https://bugs.webkit.org/show_bug.cgi?id=61912
+
+ Inlined Node::nextRenderer() and previousRenderer() into NodeRenderingContext and
+ removed original definitions.
+
+ No test, no behavioral change.
+
+ * dom/Node.cpp:
+ * dom/Node.h:
+ * dom/NodeRenderingContext.cpp:
+ (WebCore::NodeRenderingContext::nextRenderer):
+ (WebCore::NodeRenderingContext::previousRenderer):
+
+2011-06-02 Piroska András <Piroska.Andras@stud.u-szeged.hu>
+
+ Rubber-stamped by Gabor Loki.
+
+ Trivial buildfix for the ParallelJobs part of FEConvolveMatrix.
+
+ * platform/graphics/filters/FEConvolveMatrix.cpp:
+ (WebCore::FEConvolveMatrix::apply): Rename variable i to job
+
+2011-06-02 Yuta Kitamura <yutak@chromium.org>
+
+ Reviewed by Kent Tamura.
+
+ WebSocket: Call WebSocketChannel::fail() when WebSocketHandshake has failed
+ https://bugs.webkit.org/show_bug.cgi?id=61841
+
+ There is no change in behavior except that capitalization of a few error messages
+ has been changed. No new tests are added.
+
+ * websockets/WebSocketChannel.cpp:
+ (WebCore::WebSocketChannel::processBuffer):
+ Pass m_handshake.failureReason() to fail() if the handshake has failed.
+ * websockets/WebSocketHandshake.cpp:
+ Replace occurrences of m_handle->addMessage() with assignments to m_failureReason.
+ Change capitalization of a few messages so that all messages start with a capital letter.
+ (WebCore::WebSocketHandshake::readServerHandshake):
+ (WebCore::WebSocketHandshake::failureReason):
+ (WebCore::WebSocketHandshake::readStatusLine):
+ (WebCore::WebSocketHandshake::readHTTPHeaders):
+ (WebCore::WebSocketHandshake::checkResponseHeaders):
+ * websockets/WebSocketHandshake.h:
+ Add failureReason(), which returns a string that describes why WebSocket handshake
+ has failed.
+
+2011-06-01 Dan Bernstein <mitz@apple.com>
+
+ Reviewed by Anders Carlsson.
+
+ Incorrect UA style when printing a simple document
+ https://bugs.webkit.org/show_bug.cgi?id=61900
+
+ This is not testable in run-webkit-tests because unless the test is the first to run in an instance
+ of DumpRenderTree, it is not guaranteed that the full default style sheet has not been initialized.
+
+ * css/CSSStyleSelector.cpp:
+ (WebCore::loadFullDefaultStyle): Replace the simple default print style, which is now equal to the
+ simple default style, with a new RuleSet before adding the style rules from the full default sheet.
+ (WebCore::loadSimpleDefaultStyle): Set defaultPrintStyle to point to the default style. They are
+ equal in the simple case.
+
+2011-06-01 Kent Tamura <tkent@chromium.org>
+
+ Reviewed by Dimitri Glazkov.
+
+ Remove outer-spin-button
+ https://bugs.webkit.org/show_bug.cgi?id=61845
+
+ Remove outer-spin-button, and render steppers as inner-spin-button.
+ Outer-spin-button have never worked well with padding and border of
+ <input>, and the layout code is very tricky and very hard to maintain it.
+
+ * css/CSSPrimitiveValueMappings.h:
+ (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
+ * css/CSSValueKeywords.in:
+ * css/html.css:
+ * html/HTMLInputElement.cpp:
+ (WebCore::HTMLInputElement::innerSpinButtonElement):
+ * html/HTMLInputElement.h:
+ * html/InputType.h:
+ * html/TextFieldInputType.cpp:
+ (WebCore::TextFieldInputType::TextFieldInputType):
+ (WebCore::TextFieldInputType::createShadowSubtree):
+ (WebCore::TextFieldInputType::destroyShadowSubtree):
+ * html/TextFieldInputType.h:
+ * html/shadow/TextControlInnerElements.cpp:
+ (WebCore::SpinButtonElement::SpinButtonElement):
+ (WebCore::SpinButtonElement::create):
+ (WebCore::SpinButtonElement::shadowPseudoId):
+ * html/shadow/TextControlInnerElements.h:
+ * platform/ThemeTypes.h:
+ * platform/chromium/ThemeChromiumMac.mm:
+ (WebCore::paintStepper):
+ Center the stepper drawing area because the specified area can be
+ larger than the NSStepper sizes.
+ (WebCore::ThemeChromiumMac::controlSize):
+ (WebCore::ThemeChromiumMac::minimumControlSize):
+ (WebCore::ThemeChromiumMac::inflateControlPaintRect):
+ (WebCore::ThemeChromiumMac::paint):
+ * platform/mac/ThemeMac.mm:
+ (WebCore::paintStepper):
+ Center the stepper drawing area because the specified area can be
+ larger than the NSStepper sizes.
+ (WebCore::ThemeMac::controlSize):
+ (WebCore::ThemeMac::minimumControlSize):
+ (WebCore::ThemeMac::inflateControlPaintRect):
+ (WebCore::ThemeMac::paint):
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::paintBoxDecorations):
+ * rendering/RenderBox.h:
+ * rendering/RenderTextControlSingleLine.cpp:
+ (WebCore::RenderTextControlSingleLine::layout):
+ (WebCore::RenderTextControlSingleLine::nodeAtPoint):
+ (WebCore::RenderTextControlSingleLine::textBlockWidth):
+ * rendering/RenderTextControlSingleLine.h:
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::adjustStyle):
+ (WebCore::RenderTheme::paint):
+ (WebCore::RenderTheme::adjustInnerSpinButtonStyle):
+ * rendering/RenderTheme.h:
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::adjustRepaintRect):
+
+2011-06-01 Emil A Eklund <eae@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Switch RenderLayer::convertToLayerCoords to use IntPoint
+ https://bugs.webkit.org/show_bug.cgi?id=61818
+
+ Covered by existing tests.
+
+ * platform/graphics/FloatPoint.h:
+ (WebCore::flooredIntSize):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::updateLayerPositions):
+ (WebCore::expandClipRectForDescendantsAndReflection):
+ (WebCore::transparencyClipBox):
+ (WebCore::RenderLayer::convertToLayerCoords):
+ (WebCore::RenderLayer::paintLayer):
+ (WebCore::RenderLayer::paintChildLayerIntoColumns):
+ (WebCore::RenderLayer::createLocalTransformState):
+ (WebCore::RenderLayer::hitTestChildLayerColumns):
+ (WebCore::RenderLayer::calculateClipRects):
+ (WebCore::RenderLayer::calculateRects):
+ (WebCore::RenderLayer::boundingBox):
+ (WebCore::RenderLayer::setBackingNeedsRepaintInRect):
+ * rendering/RenderLayer.h:
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::updateCompositedBounds):
+ (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::calculateCompositedBounds):
+ (WebCore::RenderLayerCompositor::layerWillBeRemoved):
+ (WebCore::RenderLayerCompositor::recursiveRepaintLayerRect):
+
+2011-06-01 Roland Steiner <rolandsteiner@chromium.org>
+
+ Reviewed by Kent Tamura.
+
+ Remove superfluous renderer() test
+ https://bugs.webkit.org/show_bug.cgi?id=61907
+
+ No new tests. (trivial)
+
+ * dom/Document.cpp:
+ (WebCore::Document::recalcStyle):
+
+2011-06-01 Levi Weintraub <leviw@chromium.org>
+
+ Reviewed by Hajime Morita.
+
+ Add IntPoint + IntPoint operator
+ https://bugs.webkit.org/show_bug.cgi?id=61876
+
+ Adding an operator+ convenience method to IntPoint that sums two points
+ and returns the result as an IntPoint. Changing doImageDrag to use it
+ as a proof of concept.
+
+ No new tests since there is no change in behavior.
+
+ * page/DragController.cpp:
+ (WebCore::DragController::doImageDrag):
+ * platform/graphics/IntPoint.h:
+ (WebCore::operator+):
+
+2011-06-01 Jaehun Lim <ljaehun.lim@samsung.com>
+
+ Reviewed by Eric Seidel.
+
+ [EFL] Add adjustMenuListButtonStyle and paintMenuListButton functions
+ https://bugs.webkit.org/show_bug.cgi?id=61836
+
+ Add functions for rendering drop-down list when style attributes are applied.
+
+ * platform/efl/RenderThemeEfl.cpp:
+ (WebCore::RenderThemeEfl::adjustMenuListButtonStyle):
+ (WebCore::RenderThemeEfl::paintMenuListButton):
+ * platform/efl/RenderThemeEfl.h:
+
+2011-06-01 Yuta Kitamura <yutak@chromium.org>
+
+ Reviewed by Kent Tamura.
+
+ WebSocket: WebSocketChannel::fail() should close the connection immediately
+ https://bugs.webkit.org/show_bug.cgi?id=61851
+
+ The effect of this change is almost unobservable. The difference between m_handle->close() and
+ m_handle->disconnect() is that the former does not close the connection if the handle has
+ unsent data while the latter immediately closes the connection regardless of unsent data.
+ Usually a socket stream handle does not have unsent data, and even if it has any, it is hard
+ for user scripts to observe the difference between close() and disconnect() (it should take some time
+ for onclose() to be called if there are any unsent data, but there ought to be no other difference
+ in user scripts' perspective).
+
+ No new tests are added, because writing a test for this issue is not feasible due to the above reason.
+
+ * websockets/WebSocketChannel.cpp:
+ (WebCore::WebSocketChannel::fail): Use m_handle->disconnect() instead of m_handle->close().
+
+2011-06-01 Abhishek Arya <inferno@chromium.org>
+
+ Unreviewed.
+
+ Coding style nit. Move ec=0 initialization, change
+ recommended by Alexey in bug.
+ https://bugs.webkit.org/show_bug.cgi?id=60831
+
+ * dom/Document.cpp:
+ (WebCore::Document::setBody):
+
+2011-06-01 Hayato Ito <hayato@chromium.org>
+
+ Reviewed by Kent Tamura.
+
+ Move {Next,Previous}FocusableNode functions from Document to FocusController.
+ https://bugs.webkit.org/show_bug.cgi?id=61839
+
+ There are some member functions in Document which use 'this'
+ pointer, but we should use TreeScope instead of Document in some
+ places to handle focus issues nicely. We have to move these
+ functions out of Document class so that we can give the TreeScope
+ as a parameter.
+
+ No new tests since no functionality was changed.
+
+ * dom/Document.cpp:
+ * dom/Document.h:
+ * page/FocusController.cpp:
+ (WebCore::FocusController::deepFocusableNode):
+ (WebCore::FocusController::advanceFocusInDocumentOrder):
+ (WebCore::nextNodeWithExactTabIndex):
+ (WebCore::previousNodeWithExactTabIndex):
+ (WebCore::nextNodeWithGreaterTabIndex):
+ (WebCore::previousNodeWithLowerTabIndex):
+ (WebCore::FocusController::nextFocusableNode):
+ (WebCore::FocusController::previousFocusableNode):
+ * page/FocusController.h:
+
+2011-06-01 Adrienne Walker <enne@google.com>
+
+ Reviewed by James Robinson.
+
+ [chromium] Fix syncing of removed mask and replica layers
+ https://bugs.webkit.org/show_bug.cgi?id=61895
+
+ * platform/graphics/chromium/TreeSynchronizer.cpp:
+ (WebCore::TreeSynchronizer::synchronizeTreeRecursive):
+
+2011-06-01 Julien Chaffraix <jchaffraix@codeaurora.org>
+
+ Reviewed by Simon Fraser.
+
+ CSSStyleSheet#insertRule doesn't work well with imported stylesheets
+ https://bugs.webkit.org/show_bug.cgi?id=56981
+
+ Test: fast/css/import-and-insert-rule-no-update.html
+
+ The bug arises from the fact that <link> element did not know about a programmatically
+ loading sheet (using insertRule and @import) and would thus never call removePendingSheet.
+ This is needed to make sure our style selector contains an up-to-date list of stylesheets.
+
+ The gist of the patch adds a way for style sheet owner element to know if we are
+ programmatically loading a style sheet. This is needed as <link> keeps the information
+ about that last loaded stylesheet.
+
+ * css/CSSImportRule.cpp:
+ (WebCore::CSSImportRule::insertedIntoParent): Call startLoadingDynamicSheet
+ on our parent style sheet instead of directly adding a pending style sheet.
+
+ * css/CSSStyleSheet.cpp:
+ (WebCore::CSSStyleSheet::startLoadingDynamicSheet): Call startLoadingDynamicSheet
+ on our owner element if we have one.
+
+ * css/CSSStyleSheet.h:
+ * dom/Node.h:
+ (WebCore::Node::startLoadingDynamicSheet): Added common implementation of
+ startLoadingDynamicSheet, which should never be called.
+
+ * dom/StyleElement.cpp:
+ (WebCore::StyleElement::startLoadingDynamicSheet):
+ * dom/StyleElement.h:
+ Common implementation of startLoadingDynamicSheet for style elements.
+
+ * html/HTMLLinkElement.cpp:
+ (WebCore::HTMLLinkElement::startLoadingDynamicSheet):
+ * html/HTMLLinkElement.h:
+ Use the HTMLLinkElement plumbing to make sure we call addRemovePendingSheet.
+
+ * html/HTMLStyleElement.h:
+ (WebCore::HTMLStyleElement::startLoadingDynamicSheet):
+ * svg/SVGStyleElement.h:
+ (WebCore::SVGStyleElement::startLoadingDynamicSheet):
+ Forward the call to StyleElement.
+
+2011-06-01 Levi Weintraub <leviw@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Switch paintCustomHighlight to use IntPoint
+ https://bugs.webkit.org/show_bug.cgi?id=61562
+
+ Switching paintCustomHighlight to use an IntPoint for
+ its paint offset instead of a pair of ints.
+
+ No new tests since this is refactoring.
+
+ * rendering/InlineTextBox.cpp:
+ (WebCore::InlineTextBox::paint):
+ (WebCore::InlineTextBox::paintCustomHighlight):
+ * rendering/InlineTextBox.h:
+ * rendering/RenderBox.cpp:
+ (WebCore::RenderBox::paintCustomHighlight):
+ * rendering/RenderBox.h:
+ * rendering/RenderImage.cpp:
+ (WebCore::RenderImage::paintReplaced):
+ * rendering/RenderListMarker.cpp:
+ (WebCore::RenderListMarker::paint):
+ * rendering/RenderWidget.cpp:
+ (WebCore::RenderWidget::paint):
+ * rendering/RootInlineBox.cpp:
+ (WebCore::RootInlineBox::paintCustomHighlight):
+ (WebCore::RootInlineBox::paint):
+ * rendering/RootInlineBox.h:
+
+2011-06-01 Emil A Eklund <eae@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Switch MouseRelatedEvent to use IntPoint
+ https://bugs.webkit.org/show_bug.cgi?id=61574
+
+ Covered by existing tests.
+
+ * dom/MouseEvent.cpp:
+ (WebCore::MouseEvent::MouseEvent):
+ (WebCore::MouseEvent::initMouseEvent):
+ (WebCore::SimulatedMouseEvent::SimulatedMouseEvent):
+ * dom/MouseRelatedEvent.cpp:
+ (WebCore::MouseRelatedEvent::MouseRelatedEvent):
+ (WebCore::contentsScrollOffset):
+ (WebCore::MouseRelatedEvent::initCoordinates):
+ (WebCore::MouseRelatedEvent::computeRelativePosition):
+ (WebCore::MouseRelatedEvent::layerX):
+ (WebCore::MouseRelatedEvent::layerY):
+ (WebCore::MouseRelatedEvent::offsetX):
+ (WebCore::MouseRelatedEvent::offsetY):
+ (WebCore::MouseRelatedEvent::pageX):
+ (WebCore::MouseRelatedEvent::pageY):
+ (WebCore::MouseRelatedEvent::pageLocation):
+ (WebCore::MouseRelatedEvent::x):
+ (WebCore::MouseRelatedEvent::y):
+ * dom/MouseRelatedEvent.h:
+ (WebCore::MouseRelatedEvent::screenX):
+ (WebCore::MouseRelatedEvent::screenY):
+ (WebCore::MouseRelatedEvent::screenLocation):
+ (WebCore::MouseRelatedEvent::clientX):
+ (WebCore::MouseRelatedEvent::clientY):
+ (WebCore::MouseRelatedEvent::clientLocation):
+ (WebCore::MouseRelatedEvent::absoluteLocation):
+ * dom/TouchEvent.cpp:
+ (WebCore::TouchEvent::TouchEvent):
+ (WebCore::TouchEvent::initTouchEvent):
+ * dom/WheelEvent.cpp:
+ (WebCore::WheelEvent::WheelEvent):
+ (WebCore::WheelEvent::initWheelEvent):
+ (WebCore::WheelEventDispatchMediator::WheelEventDispatchMediator):
+ * dom/WheelEvent.h:
+ (WebCore::WheelEvent::create):
+ (WebCore::WheelEvent::wheelDelta):
+ (WebCore::WheelEvent::wheelDeltaX):
+ (WebCore::WheelEvent::wheelDeltaY):
+ (WebCore::WheelEvent::rawDeltaX):
+ (WebCore::WheelEvent::rawDeltaY):
+ (WebCore::WheelEvent::isHorizontal):
+ * platform/graphics/IntPoint.h:
+ (WebCore::IntPoint::scale):
+
+2011-06-01 Levi Weintraub <leviw@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Switch paintOverflowControls to use IntPoint
+ https://bugs.webkit.org/show_bug.cgi?id=61884
+
+ Switching paintOverflowControls to use an IntPoint instead of a pair of ints.
+
+ No new tests since this is simple refactoring.
+
+ * rendering/RenderBlock.cpp:
+ (WebCore::RenderBlock::paint):
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paintOverflowControls):
+ (WebCore::RenderLayer::paintLayer):
+ * rendering/RenderLayer.h:
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::paintIntoLayer):
+
+2011-06-01 Abhishek Arya <inferno@chromium.org>
+
+ Reviewed by Alexey Proskuryakov.
+
+ Fix setting of document.body
+ https://bugs.webkit.org/show_bug.cgi?id=60831
+
+ 1. Only allowing setting to an element if it has a body tag.
+ 2. If element is from another document, import it.
+
+ Test: fast/dom/document-set-body.html
+
+ * dom/Document.cpp:
+ (WebCore::Document::setBody):
+
+2011-06-01 Chris Fleizach <cfleizach@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Safari always crashes on http://bbc.co.uk when VoiceOver enabled
+ https://bugs.webkit.org/show_bug.cgi?id=61886
+
+ This crash can happen on webpages that remove an element from the DOM when the element receives focus.
+ When AppKit goes to post a notification to inform VoiceOver the focus has changed, it asks for the AXFocusedUIElement.
+ However by posting that notification, a render tree update is performed. This causes the element to disappear, but
+ AppKit still has a handle to it and continues to try to reference it. When the autorelease pool pops, the reference goes bad.
+
+ To fix, the root element, the AccessibilityScrollView, needs to implement updateBackingStore(), otherwise this method
+ will not be called in time.
+
+ No test could be created because to cause it depends on an internal AppKit mechanism
+ that is only triggered remotely through the accessibility runtime.
+
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::updateBackingStore):
+ * accessibility/AccessibilityObject.h:
+ * accessibility/AccessibilityRenderObject.cpp:
+ * accessibility/AccessibilityRenderObject.h:
+
+2011-06-01 David Carson <dacarson@apple.com>
+
+ Reviewed by Antti Koivisto.
+
+ https://bugs.webkit.org/show_bug.cgi?id=61831
+ If width and height of an iframe is fixed and should not be visible, then
+ it shouldn't be flattened.
+
+ Test: fast/frames/flattening/iframe-flattening-fixed-width-and-height-zero-size.html
+
+ * rendering/RenderIFrame.cpp:
+ (WebCore::RenderIFrame::flattenFrame): add a check for a zero width or height
+
+2011-06-01 Daniel Cheng <dcheng@chromium.org>
+
+ Reviewed by Tony Chang.
+
+ [chromium] Use correct file name for dragging out images.
+ https://bugs.webkit.org/show_bug.cgi?id=24887
+
+ We try to guess an appropriate filename when dragging out images. In order, we try to use:
+ - The filename suggested in the HTTP header.
+ - The last path component of the source URL.
+ - The alt text.
+ This matches the behavior of the other WebKit ports.
+
+ Test: fast/events/drag-image-filename.html
+
+ * platform/chromium/ClipboardChromium.cpp:
+ (WebCore::writeImageToDataObject):
+ * platform/chromium/ClipboardChromiumMac.cpp:
+ (WebCore::isInvalidFileCharacter):
+ (WebCore::ClipboardChromium::validateFileName):
+
+2011-06-01 Levi Weintraub <leviw@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Text is scaled in a stair-step pattern
+ https://bugs.webkit.org/show_bug.cgi?id=60317
+
+ Stop scaling the specified font to the actual on-screen value when font-rendering:
+ geometricPrecision is specified, but instead scale the graphics context. This allows
+ us to scale text up and down smoothly.
+
+ Test: svg/text/scaling-font-with-geometric-precision.html
+
+ * rendering/svg/RenderSVGInlineText.cpp:
+ (WebCore::RenderSVGInlineText::computeNewScaledFontForStyle):
+
+2011-06-01 Levi Weintraub <leviw@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Switch paintResizer to use IntPoint
+ https://bugs.webkit.org/show_bug.cgi?id=61883
+
+ Switch paintResizer to take an IntPoint instead of a pair of ints.
+
+ No new tests as this is simple refactoring.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paintOverflowControls):
+ (WebCore::RenderLayer::paintResizer):
+ * rendering/RenderLayer.h:
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::paintContents):
+
+2011-06-01 Jer Noble <jer.noble@apple.com>
+
+ Reviewed by Darin Adler.
+
+ Page layout messed up after exiting full screen at Apple trailers page
+ https://bugs.webkit.org/show_bug.cgi?id=61755
+ <rdar://problem/9525277>
+
+ Test: fullscreen/full-screen-zIndex-after.html
+
+ Fix the incomplete implementation of r87660. Make parameters to
+ setContainsFullScreenElementRecursively() in webkitWillExitFullScreenForElement() match those
+ in webkitWillEnterFullScreenForElement(), so the ancestors' flags do not become
+ inconsistent..
+
+ * dom/Document.cpp:
+ (WebCore::Document::webkitWillExitFullScreenForElement):
+
+2011-06-01 Levi Weintraub <leviw@chromium.org>
+
+ Reviewed by Eric Seidel.
+
+ Switch paintScrollCorner to use IntPoint
+ https://bugs.webkit.org/show_bug.cgi?id=61874
+
+ Changing paintScrollCorner to take an IntPoint representing the paint
+ offset instead of a pair of ints.
+
+ No new tests as this is simple refactoring.
+
+ * rendering/RenderLayer.cpp:
+ (WebCore::RenderLayer::paintOverflowControls):
+ (WebCore::RenderLayer::paintScrollCorner):
+ * rendering/RenderLayer.h:
+ * rendering/RenderLayerBacking.cpp:
+ (WebCore::RenderLayerBacking::paintContents):
+
+2011-06-01 Kenneth Russell <kbr@google.com>
+
+ Reviewed by Nate Chapin.
+
+ [V8] Optimize fetches of indexed properties in custom bindings
+ https://bugs.webkit.org/show_bug.cgi?id=61821
+
+ Avoid allocating garbage in affected custom bindings. This speeds
+ up one test case by at least a factor of two. No new tests;
+ covered by existing layout tests (typed array and otherwise).
+
+ * bindings/v8/custom/V8ArrayBufferViewCustom.h:
+ (WebCore::constructWebGLArray):
+ (WebCore::setWebGLArrayHelper):
+ * bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
+ (WebCore::V8InspectorFrontendHost::showContextMenuCallback):
+ * bindings/v8/custom/V8MessagePortCustom.cpp:
+ (WebCore::getMessagePortArray):
+ * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
+ (WebCore::jsArrayToFloatArray):
+ (WebCore::jsArrayToIntArray):
+
+2011-06-01 Andras Becsi <abecsi@webkit.org>
+
+ Reviewed by Csaba Osztrogonác.
+
+ [Qt] Fix the Phonon build when logging is disabled
+ https://bugs.webkit.org/show_bug.cgi?id=61869
+
+ No new tests needed.
+
+ * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp: Add missing guards.
+ (WebCore::MediaPlayerPrivatePhonon::networkState):
+ (WebCore::MediaPlayerPrivatePhonon::readyState):
+ (WebCore::MediaPlayerPrivatePhonon::updateStates):
+ (WebCore::MediaPlayerPrivatePhonon::stateChanged):
+
+2011-06-01 Abhishek Arya <inferno@chromium.org>
+
+ Reviewed by Antti Koivisto.
+
+ Do not use the pushed style selector if it is not equal to the
+ parent document's style selector. It usually means that it is
+ in a bad state, e.g. already cleared.
+ https://bugs.webkit.org/show_bug.cgi?id=61737
+
* dom/Element.cpp:
- (WebCore::Element::copyNonAttributeProperties):
+ (WebCore::StyleSelectorParentPusher::~StyleSelectorParentPusher):
-2011-06-05 Igor Oliveira <igor.oliveira@openbossa.org>
+2011-06-01 Levi Weintraub <leviw@chromium.org>
+ Reviewed by Eric Seidel.
+
+ Switch RenderLineBoxList intersection functions to use IntPoint
+ https://bugs.webkit.org/show_bug.cgi?id=61794
+
+ Switching rangeIntersectsRect, anyLineIntersectsRect, and lineIntersectsDirtyRect
+ to take IntPoint instead of a tx/ty to represent the offset to be applied match
+ the rect and lines' coordinates.
+
+ No new tests since this is merely refactoring.
+
+ * rendering/RenderLineBoxList.cpp:
+ (WebCore::RenderLineBoxList::rangeIntersectsRect):
+ (WebCore::RenderLineBoxList::anyLineIntersectsRect):
+ (WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
+ (WebCore::RenderLineBoxList::paint):
+ (WebCore::RenderLineBoxList::hitTest):
+ * rendering/RenderLineBoxList.h:
+
+2011-05-19 Adrienne Walker <enne@google.com>
+
+ Reviewed by James Robinson.
+
+ [chromium] Don't split long, narrow layers into multiple tiles.
+ https://bugs.webkit.org/show_bug.cgi?id=60821
+
+ This changes the heuristic for when we tile layers to be less bad
+ about wasting texture space. Long, narrow layers that are tiled with
+ a large tile size waste texture space. Now layers are only tiled if
+ they are above 512px in one dimension and extend into a second tile in
+ the other. If they are not tiled, their layer texture will exactly
+ fit their layer bounds. In particular, this will help scrollbars.
+
+ * platform/graphics/chromium/ContentLayerChromium.cpp:
+ (WebCore::ContentLayerChromium::updateLayerSize):
+ * platform/graphics/chromium/LayerRendererChromium.h:
+ (WebCore::LayerRendererChromium::maxTextureSize):
+
+2011-06-01 Cary Clark <caryclark@google.com>
+
+ Reviewed by Eric Seidel.
+
+ Ready Chromium port for Skia on Mac
+ https://bugs.webkit.org/show_bug.cgi?id=61800
+
+ Skia on Mac is not enabled. The executing
+ code is unchanged, so there are no new tests.
+
+ * platform/chromium/DragImageRef.h:
+ Use Skia for DragImageRef instead of CG.
+
+ * platform/chromium/ScrollbarThemeChromiumMac.mm:
+ (WebCore::ScrollbarThemeChromiumMac::paint):
+ Get the total matrix from Skia for the scrollbar.
+ Convert the SkCanvas into a CGContext to draw.
+
+ * platform/chromium/ThemeChromiumMac.mm:
+ (WebCore::paintStepper):
+ Ditto.
+
+2011-06-01 Yury Semikhatsky <yurys@chromium.org>
+
+ Reviewed by Pavel Feldman.
+
+ Web Inspector: allow opening inspector for existing workers
+ https://bugs.webkit.org/show_bug.cgi?id=61853
+
+ Added sidebar pane with a list of all workers. Each worker has a check box
+ that allows opening inspector for the worker.
+
+ * inspector/Inspector.json:
+ * inspector/InspectorInstrumentation.cpp:
+ (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
+ * inspector/InspectorInstrumentation.h:
+ (WebCore::InspectorInstrumentation::didStartWorkerContext):
+ * inspector/InspectorWorkerAgent.cpp:
+ (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
+ (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
+ (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::connectToWorkerContext):
+ (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::disconnectFromWorkerContext):
+ (WebCore::InspectorWorkerAgent::clearFrontend):
+ (WebCore::InspectorWorkerAgent::connectToWorker):
+ (WebCore::InspectorWorkerAgent::disconnectFromWorker):
+ (WebCore::InspectorWorkerAgent::didStartWorkerContext):
+ * inspector/InspectorWorkerAgent.h:
+ * inspector/front-end/ScriptsPanel.js:
+ (WebInspector.ScriptsPanel):
+ * inspector/front-end/Settings.js:
+ * inspector/front-end/WorkerManager.js:
+ (WebInspector.WorkerManager):
+ (WebInspector.WorkerManager.prototype._workerCreated):
+ (WebInspector.WorkerManager.prototype._sendMessageToWorkerInspector):
+ (WebInspector.WorkerManager.prototype.openWorkerInspector):
+ (WebInspector.WorkerManager.prototype.closeWorkerInspector):
+ (WebInspector.WorkerManager.prototype._workerInspectorClosing):
+ (WebInspector.WorkerMessageForwarder):
+ (WebInspector.WorkerMessageForwarder.prototype.workerCreated):
+ (WebInspector.WorkerMessageForwarder.prototype.dispatchMessageFromWorker):
+ * inspector/front-end/WorkersSidebarPane.js:
+ (WebInspector.WorkersSidebarPane):
+ (WebInspector.WorkersSidebarPane.prototype.addWorker):
+ (WebInspector.WorkerListSidebarPane):
+ (WebInspector.WorkerListSidebarPane.prototype._workerAdded):
+ (WebInspector.WorkerListSidebarPane.prototype._workerRemoved):
+ (WebInspector.WorkerListSidebarPane.prototype._workerInspectorClosed):
+ (WebInspector.WorkerListSidebarPane.prototype._addWorker):
+ (WebInspector.WorkerListSidebarPane.prototype._createCheckbox):
+ (WebInspector.WorkerListSidebarPane.prototype._workerItemClicked):
+ * workers/Worker.cpp:
+ (WebCore::Worker::notifyFinished):
+
+2011-06-01 Shishir Agrawal <shishir@chromium.org>
+
Reviewed by Tony Gentilcore.
Renaming the Page Visibility attributes as per the modified spec draft.
@@ -429,7 +1605,6 @@
* platform/graphics/gpu/LoopBlinnMathUtils.cpp:
* platform/graphics/gpu/TilingData.cpp:
-<<<<<<< .mine
2011-05-31 Justin Novosad <junov@chromium.org>
Reviewed by Stephen White.
@@ -442,7 +1617,6 @@
* platform/graphics/gpu/LoopBlinnMathUtils.cpp:
* platform/graphics/gpu/TilingData.cpp:
-=======
2011-05-31 Rob Buis <rbuis@rim.com>
Reviewed by Dirk Schulze.
@@ -573,7 +1747,6 @@
* dom/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::insertErrorMessageBlock):
->>>>>>> .r87747
2011-05-31 Andreas Kling <kling@webkit.org>
Reviewed by Antti Koivisto.
@@ -818,6 +1991,7 @@
(WebCore::isSchemeChar):
Include '+' in the list of valid characters.
+>>>>>>> .r87778
2011-05-30 Andrey Petrov <andrey.petrov@gmail.com>
Reviewed by Hajime Morita.
« no previous file with comments | « no previous file | Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698