media: Support MojoRendererService in the browser process.

media/mojo/services/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+import("//media/media_options.gni")
 import("//mojo/public/mojo_application.gni")
 
 # Target naming conventions:
 # - converters: C++/Mojo type converters.
 # - proxy: C++ implementations supported by mojo services.
 # - service: Mojo interface implementations.
 # - unittests: Unit tests for a particular class/file.
 # - test: Tests for a particular app, e.g. media.
 
+config("media_mojo_dependent_config") {

[jamesr, 2014/12/18 17:49:54]

nit: i would name this after what it does, not how it's used.

[xhwang, 2014/12/18 21:22:37]

Done.

+  defines = []

[jamesr, 2014/12/18 17:49:54]

nit: you don't have to have this, you can instead just say "defines = [ ... ] "
inside the if block

[xhwang, 2014/12/18 21:22:38]

Done.

+  if (enable_media_mojo_renderer) {
+    defines += [ "ENABLE_MEDIA_MOJO_RENDERER" ]
+  }
+}
+
 source_set("converters") {
   sources = [
     "media_type_converters.cc",
     "media_type_converters.h",
   ]
 
   deps = [
     "//base",
     "//media",
     "//media/mojo/interfaces",
@@ skipping 10 matching lines @@
 source_set("renderer_proxy") {
   sources = [
     "mojo_demuxer_stream_impl.cc",
     "mojo_demuxer_stream_impl.h",
     "mojo_renderer_factory.cc",
     "mojo_renderer_factory.h",
     "mojo_renderer_impl.cc",
     "mojo_renderer_impl.h",
   ]
 
+  all_dependent_configs = [ ":media_mojo_dependent_config" ]

[jamesr, 2014/12/18 17:49:54]

all_dependent_configs is bad - you'll set this define in lots of targets that
have nothing to do with this.  use public_configs and and, where necessary,
forward_dependent_configs_from to forward this as needed

[DaleCurtis, 2014/12/18 19:25:11]

Can you elaborate on how this will pollute non-dependent targets?

[xhwang, 2014/12/18 21:22:38]

Good point! Thanks!

+
   deps = [
     ":converters",
     "//base",
     "//media",
     "//media/mojo/interfaces",
     "//mojo/common",
     "//mojo/environment:chromium",
     "//mojo/public/c/system:for_component",
-    "//mojo/public/cpp/application",
-    "//mojo/public/interfaces/application",
   ]
 }
 
 # MediaRenderer service.
 source_set("renderer_service") {
   sources = [
     "demuxer_stream_provider_shim.cc",
     "demuxer_stream_provider_shim.h",
     "mojo_demuxer_stream_adapter.cc",
     "mojo_demuxer_stream_adapter.h",
     "mojo_renderer_service.cc",
     "mojo_renderer_service.h",
     "renderer_config.cc",
     "renderer_config.h",
     "renderer_config_default.cc",
   ]
 
+  all_dependent_configs = [ ":media_mojo_dependent_config" ]

[jamesr, 2014/12/18 17:49:54]

ditto

[xhwang, 2014/12/18 21:22:38]

Done.

+
   deps = [
     ":converters",
     "//base",
     "//media",
     "//media/mojo/interfaces",
     "//media:shared_memory_support",
     "//mojo/common",
   ]
 }
 
@@ skipping 67 matching lines @@
 group("tests") {
   testonly = true
   deps = [
     ":media_mojo_unittests",
   ]
 
   if (!is_component_build) {
     deps += [ ":media_test" ]
   }
 }