Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 712423002: Simplify some parsing-related code (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
esprehn, eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Simplify some parsing-related code We don't need a virtual createParser function because there's only one parser. Also, removed some unused oilpan code. R=esprehn@chromium.org, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dab63533fbcdbc197c94742d6997c622246222ba

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -19 lines) Patch
M sky/engine/core/dom/Document.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/Document.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M sky/engine/core/dom/DocumentParser.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/dom/DocumentParser.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 1 chunk +0 lines, -3 lines 1 comment Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
6 years, 1 month ago (2014-11-11 17:32:35 UTC) #1
esprehn
lgtm https://codereview.chromium.org/712423002/diff/1/sky/engine/core/dom/Element.cpp File sky/engine/core/dom/Element.cpp (left): https://codereview.chromium.org/712423002/diff/1/sky/engine/core/dom/Element.cpp#oldcode1723 sky/engine/core/dom/Element.cpp:1723: startLineNumber = document().scriptableDocumentParser()->lineNumber(); CSP!!
6 years, 1 month ago (2014-11-11 17:53:39 UTC) #3
abarth-chromium
6 years, 1 month ago (2014-11-11 17:56:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dab63533fbcdbc197c94742d6997c622246222ba.

Powered by Google App Engine
This is Rietveld 408576698