Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1387)

Unified Diff: Source/devtools/front_end/devtools_app/DevToolsApp.js

Issue 712403002: [DevTools] Move extension embedder message to InspectorFrontentAPI. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/devtools_app/DevToolsApp.js
diff --git a/Source/devtools/front_end/devtools_app/DevToolsApp.js b/Source/devtools/front_end/devtools_app/DevToolsApp.js
index 38652b27937c172e52fb27d880d9977b4349f628..988422d53e253b0506a460fe2b37e22c90957e38 100644
--- a/Source/devtools/front_end/devtools_app/DevToolsApp.js
+++ b/Source/devtools/front_end/devtools_app/DevToolsApp.js
@@ -10,12 +10,6 @@ WebInspector.DevToolsApp = function()
{
window.InspectorAppHost = this;
- // FIXME: These methods are invoked from the backend and should be removed
- // once we migrate to the "pull" model for extensions retrieval.
- WebInspector.addExtensions = this._wrapInvocation.bind(this, "addExtensions");
- WebInspector.setInspectedTabId = this._wrapInvocation.bind(this, "setInspectedTabId");
- this._invokeOnWebInspectorOnceLoaded = [];
-
/**
* @type {?Window}
*/
@@ -50,33 +44,6 @@ WebInspector.DevToolsApp.prototype = {
*/
afterInspectorAppLoad: function()
{
- while (this._invokeOnWebInspectorOnceLoaded.length) {
- var methodAndParams = this._invokeOnWebInspectorOnceLoaded.shift();
- this._invokeOnWebInspector(methodAndParams[0], methodAndParams[1]);
- }
- },
-
- /**
- * @param {string} method
- */
- _wrapInvocation: function(method)
- {
- var params = Array.prototype.slice.call(arguments, 1);
- if (this._inspectorWindow) {
- this._invokeOnWebInspector(method, params);
- } else {
- this._invokeOnWebInspectorOnceLoaded.push([method, params]);
- }
- },
-
- /**
- * @param {string} method
- * @param {!Array.<*>} params
- */
- _invokeOnWebInspector: function(method, params)
- {
- var webInspector = this._inspectorWindow["WebInspector"];
- webInspector[method].apply(webInspector, params);
}
}
« no previous file with comments | « LayoutTests/http/tests/inspector/extensions-test.js ('k') | Source/devtools/front_end/extensions/ExtensionAPI.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698