ntp4: notification area

ntp4: add a notification area

This is basically a port of the ntp3 notification area, except it allows multiple links.

I think there are currently some minor bugs around most visited deletion and undo; think of this changeset as just a new piece of UI, and I will improve the functionality later.

BUG=none
TEST=[x] a most visited thumbnail and then undo

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88442

[Rick Byers, 2011-06-08 20:41:10]

LGTM.

http://codereview.chromium.org/7124002/diff/2001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/new_tab.css (right):

http://codereview.chromium.org/7124002/diff/2001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/new_tab.css:55: display: inline-block;
This seems unusual to me.  You really want to set display on all decendants of
#notification regardless of what they are?  I'm not enough of a CSS expert to
know if this is ok or not - just seems odd.  Maybe deserves a comment?  I see
elsewhere we sometimes do this to all chidlren - which makes more sense than all
descendants to me...

http://codereview.chromium.org/7124002/diff/2001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/new_tab.js (right):

http://codereview.chromium.org/7124002/diff/2001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/new_tab.js:389: * @param {array} links An array of
objects describing the links in the
You could precisely describe the type using closure type syntax, I think it's:
{Array.<{{text:string, action: function()}}>}

[Evan Stade, 2011-06-08 23:54:47]

http://codereview.chromium.org/7124002/diff/2001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/new_tab.css (right):

http://codereview.chromium.org/7124002/diff/2001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/new_tab.css:55: display: inline-block;
On 2011/06/08 20:41:10, rbyers wrote:
> This seems unusual to me.  You really want to set display on all decendants of
> #notification regardless of what they are?  I'm not enough of a CSS expert to
> know if this is ok or not - just seems odd.  Maybe deserves a comment?  I see
> elsewhere we sometimes do this to all chidlren - which makes more sense than
all
> descendants to me...

yes, this is what I want, but I can understand your concern, so I'll change it
to be more specific.

http://codereview.chromium.org/7124002/diff/2001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/new_tab.js (right):

http://codereview.chromium.org/7124002/diff/2001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/new_tab.js:389: * @param {array} links An array of
objects describing the links in the
On 2011/06/08 20:41:10, rbyers wrote:
> You could precisely describe the type using closure type syntax, I think it's:
> {Array.<{{text:string, action: function()}}>}

yes, I think that's it except with one fewer pair of curlies. thanks.