guard call to CGColorSpaceCopyICCProfile in case we're building for iOS

guard call to CGColorSpaceCopyICCProfile in case we're building for iOS

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/ddbc491151cfd77515d52c196c0c99d5165fbe2a

[reed1, 2014-11-11 15:03:19]

reed@google.com changed reviewers:
+ mtklein@google.com

[reed1, 2014-11-11 15:04:12]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-11-11 15:04:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/712363003/1

[commit-bot: I haz the power, 2014-11-11 15:04:17]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-11-11 21:04 UTC

[reed1, 2014-11-11 15:05:14]

The CQ bit was unchecked by reed@google.com

[mtklein, 2014-11-11 15:08:52]

https://codereview.chromium.org/712363003/diff/1/src/ports/SkImageDecoder_CG.cpp
File src/ports/SkImageDecoder_CG.cpp (right):

https://codereview.chromium.org/712363003/diff/1/src/ports/SkImageDecoder_CG....
src/ports/SkImageDecoder_CG.cpp:109: static bool icc_profile_is_sRGB(const void*
data, size_t length) {
Seems like a good candidate to inline into colorspace_is_sRGB, if only to keep
the SK_BUILD_FOR_IOS check really localized.

https://codereview.chromium.org/712363003/diff/1/src/ports/SkImageDecoder_CG....
src/ports/SkImageDecoder_CG.cpp:127: CFDataRef get() { return fDR; }
get() is dead?

https://codereview.chromium.org/712363003/diff/1/src/ports/SkImageDecoder_CG....
src/ports/SkImageDecoder_CG.cpp:132: return true;    // iOS seems to define
itself to always return sRGB...I think
I think -> reed thinks?

[reed1, 2014-11-11 15:19:06]

https://codereview.chromium.org/712363003/diff/1/src/ports/SkImageDecoder_CG.cpp
File src/ports/SkImageDecoder_CG.cpp (right):

https://codereview.chromium.org/712363003/diff/1/src/ports/SkImageDecoder_CG....
src/ports/SkImageDecoder_CG.cpp:109: static bool icc_profile_is_sRGB(const void*
data, size_t length) {
On 2014/11/11 15:08:51, mtklein wrote:
> Seems like a good candidate to inline into colorspace_is_sRGB, if only to keep
> the SK_BUILD_FOR_IOS check really localized.

Done.

https://codereview.chromium.org/712363003/diff/1/src/ports/SkImageDecoder_CG....
src/ports/SkImageDecoder_CG.cpp:127: CFDataRef get() { return fDR; }
On 2014/11/11 15:08:52, mtklein wrote:
> get() is dead?

Done.

https://codereview.chromium.org/712363003/diff/1/src/ports/SkImageDecoder_CG....
src/ports/SkImageDecoder_CG.cpp:132: return true;    // iOS seems to define
itself to always return sRGB...I think
On 2014/11/11 15:08:52, mtklein wrote:
> I think -> reed thinks?

Done.

[reed1, 2014-11-11 15:19:22]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2014-11-11 15:19:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/712363003/40001

[commit-bot: I haz the power, 2014-11-11 15:19:29]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2014-11-11 21:19 UTC

[mtklein, 2014-11-11 15:25:05]

lgtm

[commit-bot: I haz the power, 2014-11-11 15:27:28]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/ddbc491151cfd77515d52c196c0c99d5165fbe2a