Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 712333003: Revert "Classes: Add support for arguments in default constructor" (Closed)

Created:
6 years, 1 month ago by arv (Not doing code reviews)
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert "Classes: Add support for arguments in default constructor" This reverts commit 3f4ea6c91a962a04407c79f08e5c86ce9ff2911a. Broke tests on Mac64 http://build.chromium.org/p/client.v8/builders/V8%20Mac64/builds/923/steps/Check/logs/classes BUG=v8:3672 TBR=dslomov@chromium.org LOG=N Committed: https://code.google.com/p/v8/source/detail?r=25269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -122 lines) Patch
M src/parser.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +1 line, -5 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +8 lines, -17 lines 0 comments Download
M test/mjsunit/harmony/classes.js View 1 chunk +0 lines, -49 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
arv (Not doing code reviews)
6 years, 1 month ago (2014-11-11 16:22:19 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25269 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698