chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc - Issue 71233003: [SyncFS] Delete local file on rename and reorganize completion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

Issue 71233003: [SyncFS] Delete local file on rename and reorganize completion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@00_completion

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync_file_system/drive_backend/metadata_database.cc ('K') | « chrome/browser/sync_file_system/drive_backend/metadata_database.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc b/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

index 171de68afae215b0b23b2158dc436fa4788dacd0..8264efd5d61cc496e146e2fb01fb64b5d5b7b0bf 100644

--- a/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

+++ b/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc

@@ -487,8 +487,8 @@ void RemoteToLocalSyncer::HandleRename(

DCHECK_NE(dirty_tracker_->synced_details().title(),

remote_metadata_->details().title());

- NOTIMPLEMENTED();

- callback.Run(SYNC_STATUS_FAILED);

+ Prepare(base::Bind(&RemoteToLocalSyncer::DidPrepareForDeletion,

+ weak_ptr_factory_.GetWeakPtr(), callback));

}

void RemoteToLocalSyncer::HandleReorganize(

@@ -596,6 +596,7 @@ void RemoteToLocalSyncer::SyncCompleted(const SyncStatusCallback& callback,

DCHECK(dirty_tracker_);

DCHECK(remote_metadata_);

DCHECK(remote_metadata_->has_details());

metadata_database()->UpdateTracker(dirty_tracker_->tracker_id(),

remote_metadata_->details(),

callback);