Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 712313003: Exposing AXRole* correctly for HTML input types on mac. (Closed)

Created:
6 years, 1 month ago by shreeramk
Modified:
6 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Exposing AXRole* correctly for HTML input types on mac. BUG=418486 Committed: https://crrev.com/76eafd0a8468d0149e84adbe111914553dd6b346 Cr-Commit-Position: refs/heads/master@{#304628}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Updating expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -69 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 3 2 chunks +1 line, -4 lines 0 comments Download
M content/test/data/accessibility/input-color.html View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/data/accessibility/input-color-expected-mac.txt View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/input-date.html View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/data/accessibility/input-date-expected-mac.txt View 1 2 3 1 chunk +14 lines, -14 lines 0 comments Download
M content/test/data/accessibility/input-datetime.html View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/data/accessibility/input-datetime-expected-mac.txt View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M content/test/data/accessibility/input-datetime-local.html View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/data/accessibility/input-datetime-local-expected-mac.txt View 1 2 3 1 chunk +18 lines, -18 lines 0 comments Download
M content/test/data/accessibility/input-month.html View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/data/accessibility/input-month-expected-mac.txt View 1 2 3 1 chunk +11 lines, -11 lines 0 comments Download
M content/test/data/accessibility/input-time.html View 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-time-expected-mac.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/test/data/accessibility/input-week.html View 1 chunk +3 lines, -0 lines 0 comments Download
M content/test/data/accessibility/input-week-expected-mac.txt View 1 2 3 1 chunk +13 lines, -13 lines 0 comments Download
M ui/accessibility/platform/ax_platform_node_mac.mm View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
shreeramk
Please review. Thanks!
6 years, 1 month ago (2014-11-13 06:51:06 UTC) #2
shreeramk
On 2014/11/13 06:51:06, shreeramk wrote: > Please review. > > Thanks! @Dominic: PTAL. Thanks!1
6 years, 1 month ago (2014-11-18 15:21:53 UTC) #3
dmazzoni
lgtm
6 years, 1 month ago (2014-11-18 16:39:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712313003/60001
6 years, 1 month ago (2014-11-18 16:40:11 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-11-18 17:25:25 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-18 17:26:08 UTC) #8
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/76eafd0a8468d0149e84adbe111914553dd6b346
Cr-Commit-Position: refs/heads/master@{#304628}

Powered by Google App Engine
This is Rietveld 408576698