Fix CPU(32BIT) definition

Fix CPU(32BIT) definition

Previously WTF_CPU_32BIT definition is inside #if of ARM.
This CL make CPU(32BIT) true on all architectures if and only if not CPU(64BIT).

BUG=432033
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185196

[hiroshige, 2014-11-11 07:18:17]

hiroshige@chromium.org changed reviewers:
+ cevans@chromium.org

[hiroshige, 2014-11-11 07:28:14]

hiroshige@chromium.org changed reviewers:
+ tsepez@chromium.org

[hiroshige, 2014-11-11 07:39:46]

I tested on Windows and CPU(32BIT) was not true in Win32.
Since https://codereview.chromium.org/25640003

cevans@, could you take a look as wtf/ owner?

tsepez@, your change (https://codereview.chromium.org/408483004) is not enabled
on Win32 due to this issue (and thus maybe not tested properly), and this CL
will enable your change.

[Tom Sepez, 2014-11-11 18:27:47]

Nice catch. LGTM.

[Chris Evans, 2014-11-12 07:31:38]

On 2014/11/11 07:39:46, hiroshige wrote:
> I tested on Windows and CPU(32BIT) was not true in Win32.
> Since https://codereview.chromium.org/25640003
> 
> cevans@, could you take a look as wtf/ owner?
> 
> tsepez@, your change (https://codereview.chromium.org/408483004) is not
enabled
> on Win32 due to this issue (and thus maybe not tested properly), and this CL
> will enable your change.

Oh whoops!

LGTM

Thanks.

[hiroshige, 2014-11-12 07:54:42]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2014-11-12 07:55:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/712303003/1

[commit-bot: I haz the power, 2014-11-12 10:13:40]

Committed patchset #1 (id:1) as 185196

[Stephen White, 2014-11-12 13:02:18]

On 2014/11/12 10:13:40, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1) as 185196

Is it possible this change is causing Win XP bots to fail? It looks like all
tests are crashing at startup (layout, webkit_unit_tests, etc). E.g.,

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/15182

Maybe XP is trying to run a 64-bit build? (Just a guess.)

[hiroshige (private), 2014-11-12 14:29:52]

> Is it possible this change is causing Win XP bots to fail? It looks like all
> tests are crashing at startup (layout, webkit_unit_tests, etc). E.g.,
> 
> http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/15182
> 
> Maybe XP is trying to run a 64-bit build? (Just a guess.)

Yes, if XP bots are older than XP SP2.
This CL enables the change in
https://codereview.chromium.org/408483004,
and it calls IsWow64Process() on Win32 environment.
I found IsWow64Process() doesn't exist Windows older than XP SP2:
http://msdn.microsoft.com/ja-jp/library/windows/desktop/ms684139%28v=vs.85%29...

tsepez@, could you double-check this?

[Stephen White, 2014-11-12 15:22:44]

On 2014/11/12 14:29:52, hiroshige (private) wrote:
> > Is it possible this change is causing Win XP bots to fail? It looks like all
> > tests are crashing at startup (layout, webkit_unit_tests, etc). E.g.,
> > 
> >
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/15182
> > 
> > Maybe XP is trying to run a 64-bit build? (Just a guess.)
> 
> Yes, if XP bots are older than XP SP2.
> This CL enables the change in
> https://codereview.chromium.org/408483004,
> and it calls IsWow64Process() on Win32 environment.
> I found IsWow64Process() doesn't exist Windows older than XP SP2:
>
http://msdn.microsoft.com/ja-jp/library/windows/desktop/ms684139%28v=vs.85%29...
> 
> tsepez@, could you double-check this?

It's SP3.

[Stephen White, 2014-11-12 15:30:20]

On 2014/11/12 15:22:44, Stephen White wrote:
> On 2014/11/12 14:29:52, hiroshige (private) wrote:
> > > Is it possible this change is causing Win XP bots to fail? It looks like
all
> > > tests are crashing at startup (layout, webkit_unit_tests, etc). E.g.,
> > > 
> > >
> http://build.chromium.org/p/chromium.webkit/builders/WebKit%20XP/builds/15182
> > > 
> > > Maybe XP is trying to run a 64-bit build? (Just a guess.)
> > 
> > Yes, if XP bots are older than XP SP2.
> > This CL enables the change in
> > https://codereview.chromium.org/408483004,
> > and it calls IsWow64Process() on Win32 environment.
> > I found IsWow64Process() doesn't exist Windows older than XP SP2:
> >
>
http://msdn.microsoft.com/ja-jp/library/windows/desktop/ms684139%28v=vs.85%29...
> > 
> > tsepez@, could you double-check this?
> 
> It's SP3.

I'm going to roll this out speculatively to try to get the bots un-crashy (just
hiroshige@'s 
change; I'll leave it up to you guys to decide what to do about tsepez@'s
change).

[Tom Sepez, 2014-11-12 17:49:05]

> I'm going to roll this out speculatively to try to get the bots un-crashy
(just
> hiroshige@'s 
> change; I'll leave it up to you guys to decide what to do about tsepez@'s
> change).
The right way forward on this is to roll out my patch, re-enable hiroshige's
patch, and then work on fixing mine.  That way, when my patch does re-land, the
CQ will actually apply the testing we thought it did the first time around.

I'll cobble a revert.

[jschuh, 2014-11-12 23:53:07]

Leaving a drive-by comment. IsWow64Process() is supported on every version of
Windows Chrome supports (bots included), so it's definitely safe once the other
details get worked out.

[hiroshige, 2014-11-19 04:45:20]

Patchset #2 (id:20001) has been deleted