Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 712303002: [ServiceWorker] Add LayoutTests for the fallback behavior of FetchEvent. (Closed)

Created:
6 years, 1 month ago by horo
Modified:
6 years, 1 month ago
Reviewers:
nhiroki
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[ServiceWorker] Add LayoutTests for the fallback behavior of FetchEvent. Currently the fallback behavior for redirect responses is not implemented correctly. https://codereview.chromium.org/705273004/ will fix this problem. This patch adds LayoutTests for this bug. BUG=431985 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185185

Patch Set 1 : #

Total comments: 2

Patch Set 2 : incorporated nhiroki's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -0 lines) Patch
A LayoutTests/http/tests/serviceworker/fetch-request-fallback.html View 1 1 chunk +114 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/resources/fetch-request-fallback-iframe.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/serviceworker/resources/fetch-request-fallback-worker.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
horo
nhiroki@ Could you please review this?
6 years, 1 month ago (2014-11-11 05:43:14 UTC) #4
nhiroki
https://codereview.chromium.org/712303002/diff/40001/LayoutTests/http/tests/serviceworker/fetch-request-fallback.html File LayoutTests/http/tests/serviceworker/fetch-request-fallback.html (right): https://codereview.chromium.org/712303002/diff/40001/LayoutTests/http/tests/serviceworker/fetch-request-fallback.html#newcode78 LayoutTests/http/tests/serviceworker/fetch-request-fallback.html:78: REDIRECT_URL + encodeURIComponent(BASE_URL + 'ACAOrigin=*')); "OTHER_BASE_URL + 'ACAOrigin=*'" seems ...
6 years, 1 month ago (2014-11-11 07:58:04 UTC) #5
horo
thank you https://codereview.chromium.org/712303002/diff/40001/LayoutTests/http/tests/serviceworker/fetch-request-fallback.html File LayoutTests/http/tests/serviceworker/fetch-request-fallback.html (right): https://codereview.chromium.org/712303002/diff/40001/LayoutTests/http/tests/serviceworker/fetch-request-fallback.html#newcode78 LayoutTests/http/tests/serviceworker/fetch-request-fallback.html:78: REDIRECT_URL + encodeURIComponent(BASE_URL + 'ACAOrigin=*')); On 2014/11/11 ...
6 years, 1 month ago (2014-11-11 08:28:31 UTC) #6
nhiroki
lgtm
6 years, 1 month ago (2014-11-11 14:00:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712303002/60001
6 years, 1 month ago (2014-11-12 07:10:20 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 07:12:09 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:60001) as 185185

Powered by Google App Engine
This is Rietveld 408576698