Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: src/arm/macro-assembler-arm.h

Issue 7122003: Make x64 to use the RecordWrite stub. This is a step towards getting (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/gc/
Patch Set: '' Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/arm/macro-assembler-arm.h
===================================================================
--- src/arm/macro-assembler-arm.h (revision 8207)
+++ src/arm/macro-assembler-arm.h (working copy)
@@ -84,7 +84,7 @@
enum LinkRegisterStatus { kLRHasNotBeenSaved, kLRHasBeenSaved };
-bool Aliasing(Register r1, Register r2, Register r3, Register r4);
+bool AreAliased(Register r1, Register r2, Register r3, Register r4);
// MacroAssembler implements a collection of frequently used macros.
@@ -177,9 +177,9 @@
kFallThroughAtEnd
};
- // For page containing |object| mark region covering |addr| dirty.
- // RememberedSetHelper only works if the object is not in new
- // space.
+ // Record in the remembered set the fact that we have a pointer to new space
+ // at the address pointed to by the addr register. Only works if addr is not
+ // in new space.
void RememberedSetHelper(Register addr,
Register scratch,
SaveFPRegsMode save_fp,
@@ -235,11 +235,9 @@
// Notify the garbage collector that we wrote a pointer into an object.
// |object| is the object being stored into, |value| is the object being
- // stored. All registers are clobbered by the operation. RecordWriteField
- // filters out smis so it does not update the write barrier if the value is a
- // smi. The offset is the offset from the start of the object, not the offset
- // from the tagged HeapObject pointer. For use with
- // FieldMemOperand(reg, off)
+ // stored. value and scratch registers are clobbered by the operation.
+ // The offset is the offset from the start of the object, not the offset from
+ // the tagged HeapObject pointer. For use with FieldOperand(reg, off).
void RecordWriteField(
Register object,
int offset,
« no previous file with comments | « no previous file | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698