Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Issue 712183002: Navigation transitions (web to native app): Hide/Show transition elements (Chrome side) (Closed)

Created:
6 years, 1 month ago by Zhen Wang
Modified:
6 years, 1 month ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Navigation transitions (web to native app): Hide/Show transition elements (Chrome side) We need a way to show hidden transition elements when coming back from native app (when back button is pressed). This is the Chrome side of the CL. The Blink side has been committed here: https://codereview.chromium.org/715653004/ BUG=370696 Committed: https://crrev.com/abf9b9db989c57de0a858bbcf7af8b06068b906a Cr-Commit-Position: refs/heads/master@{#304348}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_android.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 1 2 chunks +18 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/WebContents.java View 1 1 chunk +10 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (5 generated)
Zhen Wang
ptal
6 years, 1 month ago (2014-11-12 15:33:38 UTC) #2
nasko
On 2014/11/12 15:33:38, Zhen Wang wrote: > ptal Please have someone with more knowledge on ...
6 years, 1 month ago (2014-11-12 22:16:23 UTC) #3
Zhen Wang
Hi Daniel, can you take a look at the android part? Thanks!
6 years, 1 month ago (2014-11-12 22:18:48 UTC) #5
no sievers
On 2014/11/12 22:18:48, Zhen Wang wrote: > Hi Daniel, can you take a look at ...
6 years, 1 month ago (2014-11-12 23:21:10 UTC) #6
Zhen Wang
Sure. Hi Simon, can you take a look? I will ask Daniel and Nasko to ...
6 years, 1 month ago (2014-11-12 23:23:46 UTC) #7
shatch
On 2014/11/12 23:23:46, Zhen Wang wrote: > Sure. > > Hi Simon, can you take ...
6 years, 1 month ago (2014-11-13 14:42:33 UTC) #8
no sievers
On 2014/11/13 14:42:33, shatch wrote: > On 2014/11/12 23:23:46, Zhen Wang wrote: > > Sure. ...
6 years, 1 month ago (2014-11-13 20:37:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712183002/60001
6 years, 1 month ago (2014-11-14 15:23:43 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/24228)
6 years, 1 month ago (2014-11-14 15:27:51 UTC) #13
Zhen Wang
Hi Nasko, can you take a look? Simon and Daniel are ok with it now. ...
6 years, 1 month ago (2014-11-14 15:31:55 UTC) #14
nasko
LGTM
6 years, 1 month ago (2014-11-15 00:07:42 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712183002/60001
6 years, 1 month ago (2014-11-15 04:01:16 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-11-15 04:04:26 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-11-15 04:05:18 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/abf9b9db989c57de0a858bbcf7af8b06068b906a
Cr-Commit-Position: refs/heads/master@{#304348}

Powered by Google App Engine
This is Rietveld 408576698