Issue 712163003: Avoid the use of mipmaps to prevent memory leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 712163003: Avoid the use of mipmaps to prevent memory leak. (Closed)

Created:
6 years, 1 month ago by reveman

Modified:
6 years, 1 month ago

Reviewers:
reed1

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@m39

Project:
skia

Visibility:
Public.

More Reviews

Description

Avoid the use of mipmaps to prevent memory leak. BUG=420816

Patch Set 2 : #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -30 lines)			Patch
	M	src/core/SkBitmapProcState.cpp	View	1	1 chunk	+3 lines, -30 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

reed1

https://codereview.chromium.org/712163003/diff/1/src/core/SkBitmapProcState.cpp File src/core/SkBitmapProcState.cpp (left): https://codereview.chromium.org/712163003/diff/1/src/core/SkBitmapProcState.cpp#oldcode256 src/core/SkBitmapProcState.cpp:256: * Medium quality means use a mipmap for down-scaling, ...

6 years, 1 month ago (2014-11-11 14:44:13 UTC) #2

reveman

PTAL https://codereview.chromium.org/712163003/diff/1/src/core/SkBitmapProcState.cpp File src/core/SkBitmapProcState.cpp (left): https://codereview.chromium.org/712163003/diff/1/src/core/SkBitmapProcState.cpp#oldcode256 src/core/SkBitmapProcState.cpp:256: * Medium quality means use a mipmap for ...

6 years, 1 month ago (2014-11-11 14:56:38 UTC) #3

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 712163003: Avoid the use of mipmaps to prevent memory leak. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages