Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 712143004: Merge CSSDefaultStyleSheets into StyleResolver. (Closed)

Created:
6 years, 1 month ago by esprehn
Modified:
6 years, 1 month ago
Reviewers:
ojan, abarth-chromium
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -155 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
D sky/engine/core/css/CSSDefaultStyleSheets.h View 1 chunk +0 lines, -57 lines 0 comments Download
D sky/engine/core/css/CSSDefaultStyleSheets.cpp View 1 chunk +0 lines, -86 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 6 chunks +33 lines, -10 lines 1 comment Download

Messages

Total messages: 6 (2 generated)
esprehn
6 years, 1 month ago (2014-11-11 02:11:24 UTC) #2
ojan
lgtm https://codereview.chromium.org/712143004/diff/1/sky/engine/core/css/resolver/StyleResolver.cpp File sky/engine/core/css/resolver/StyleResolver.cpp (right): https://codereview.chromium.org/712143004/diff/1/sky/engine/core/css/resolver/StyleResolver.cpp#newcode374 sky/engine/core/css/resolver/StyleResolver.cpp:374: matchUARules(collector, &defaultStyles()); FWIW, we need to get rid ...
6 years, 1 month ago (2014-11-11 02:41:51 UTC) #3
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-11 02:42:13 UTC) #5
esprehn
6 years, 1 month ago (2014-11-11 02:50:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e556bc541e6fb02a303ea0773ad4767d3fbc5129.

Powered by Google App Engine
This is Rietveld 408576698