Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(1016)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: resources/invalid_images/sigsegv_favicon_2.ico
Issue
712123002
:
Add tests (and fix!) for known bad ICO files. (Closed)
Base URL: https://skia.googlesource.com/skia.git@master
Patch Set:
Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
gyp/tests.gypi
resources/invalid_images/sigabort_favicon.ico
resources/invalid_images/sigsegv_favicon.ico
resources/invalid_images/sigsegv_favicon_2.ico
src/images/SkImageDecoder_libico.cpp
tests/BadIcoTest.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« resources/invalid_images/sigsegv_favicon.ico
('k') |
src/images/SkImageDecoder_libico.cpp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
OLD
NEW
« no previous file with comments
|
« resources/invalid_images/sigsegv_favicon.ico
('k') |
src/images/SkImageDecoder_libico.cpp »
('j') |
no next file with comments »
Issue 712123002: Add tests (and fix!) for known bad ICO files. (Closed)
Created 6 years, 1 month ago by scroggo
Modified 6 years, 1 month ago
Reviewers: djsollen
Base URL: https://skia.googlesource.com/skia.git@master
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 712123002:
Add tests (and fix!) for known bad ICO files. (Closed)
Base URL: https://skia.googlesource.com/skia.git@master
