Issue 712123002: Add tests (and fix!) for known bad ICO files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 712123002: Add tests (and fix!) for known bad ICO files. (Closed)

Created:
6 years, 1 month ago by scroggo

Modified:
6 years, 1 month ago

Reviewers:
djsollen

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Add tests (and fix!) for known bad ICO files. We previously saw crashes decoding bad ICO files. Add tests for known bad files. While testing, I learned that one of them still crashes. Check for large offset and size separately to fix the crash. BUG=skia:2878 Committed: https://skia.googlesource.com/skia/+/b61e206138607423e83ba34d823c6036f394f655

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -1 line)			Patch
M	gyp/tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	resources/invalid_images/sigabort_favicon.ico	View	Binary file		0 comments	Download
A	resources/invalid_images/sigsegv_favicon.ico	View	Binary file		0 comments	Download
A	resources/invalid_images/sigsegv_favicon_2.ico	View	Binary file		0 comments	Download
M	src/images/SkImageDecoder_libico.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
A	tests/BadIcoTest.cpp	View	1 chunk	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/712123002/1

6 years, 1 month ago (2014-11-10 21:04:38 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-11-10 21:12:32 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b61e206138607423e83ba34d823c6036f394f655

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages