Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 712083002: Add optional max elements limit for Map/Set mirror iterator preview. (Closed)

Created:
6 years, 1 month ago by aandrey
Modified:
6 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add optional max elements limit for Map/Set mirror iterator preview. R=yangguo@chromium.org LOG=N Committed: https://code.google.com/p/v8/source/detail?r=25257

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -32 lines) Patch
M src/mirror-debugger.js View 5 chunks +18 lines, -11 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-collections.cc View 2 chunks +25 lines, -16 lines 0 comments Download
M test/mjsunit/es6/mirror-collections.js View 6 chunks +11 lines, -0 lines 0 comments Download
M test/mjsunit/es6/mirror-iterators.js View 3 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
aandrey
6 years, 1 month ago (2014-11-10 14:47:41 UTC) #1
Yang
On 2014/11/10 14:47:41, aandrey wrote: lgtm
6 years, 1 month ago (2014-11-11 08:44:01 UTC) #2
aandrey
6 years, 1 month ago (2014-11-11 09:46:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25257 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698