[Android WebView] Unflake AwViewportTest#testInitialScaleClobberQuirk

[Android WebView] Unflake AwViewportTest#testInitialScaleClobberQuirk

Make the test resilient to spurious page scale changes that
can occur after calling WebView.setInitialScale.

Also, update AwViewportTest#testNoUserScalableQuirk to wait
for page scale change events instead of page scale polling.

BUG=319353
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235671

[mkosiba (inactive), 2013-11-15 14:53:11]

lgtm

https://codereview.chromium.org/71203004/diff/30001/android_webview/javatests...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwViewportTest.java
(right):

https://codereview.chromium.org/71203004/diff/30001/android_webview/javatests...
android_webview/javatests/src/org/chromium/android_webview/test/AwViewportTest.java:254:
// flaky. So instead, we are just polling the scale until it becomes 1.0.
this sounds scary. Do we know why such a change happens?

[mnaganov (inactive), 2013-11-16 00:41:09]

https://codereview.chromium.org/71203004/diff/30001/android_webview/javatests...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwViewportTest.java
(right):

https://codereview.chromium.org/71203004/diff/30001/android_webview/javatests...
android_webview/javatests/src/org/chromium/android_webview/test/AwViewportTest.java:254:
// flaky. So instead, we are just polling the scale until it becomes 1.0.
On 2013/11/15 14:53:11, mkosiba wrote:
> this sounds scary. Do we know why such a change happens?

Not scary at all. Setting initial scale triggers a relayout, which may cause a
page scale update. But I don't want the test to depend on this, because this is
an implementation detail which may change some day.

[commit-bot: I haz the power, 2013-11-16 02:01:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnaganov@chromium.org/71203004/110001

[commit-bot: I haz the power, 2013-11-18 08:42:07]

Change committed as 235671

[mkosiba (inactive), 2013-11-19 00:49:59]

https://codereview.chromium.org/71203004/diff/30001/android_webview/javatests...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwViewportTest.java
(right):

https://codereview.chromium.org/71203004/diff/30001/android_webview/javatests...
android_webview/javatests/src/org/chromium/android_webview/test/AwViewportTest.java:254:
// flaky. So instead, we are just polling the scale until it becomes 1.0.
On 2013/11/16 00:41:09, Mikhail Naganov (Chromium) wrote:
> On 2013/11/15 14:53:11, mkosiba wrote:
> > this sounds scary. Do we know why such a change happens?
> 
> Not scary at all. Setting initial scale triggers a relayout, which may cause a
> page scale update. But I don't want the test to depend on this, because this
is
> an implementation detail which may change some day.

Ah, ok. I didn't realize setting initial scale triggers a layout. Thanks for the
explanation!