Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 711973002: Remove FileTest.MemoryCorruption death test regexp assertions. (Closed)

Created:
6 years, 1 month ago by gavinp
Modified:
6 years, 1 month ago
Reviewers:
Nico, pucchakayala
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@checksum_fds_by_master
Project:
chromium
Visibility:
Public.

Description

Remove FileTest.MemoryCorruption death test regexp assertions. The stacks on the 8011 builders don't include debug crash messages apparently; so the FileTest.MemoryCorruption unit tests were causing failures on those builders. Removing all the assertions should fix those builders at the cost of losing a bit of test specificity. TBR=pucchakayala@chromium.org,thakis@chromium.org BUG=431425 Committed: https://crrev.com/1694addd2c0b173a6a95ce675b7c38a268eddba4 Cr-Commit-Position: refs/heads/master@{#303408}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M base/files/file_unittest.cc View 6 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711973002/1
6 years, 1 month ago (2014-11-09 21:01:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-09 21:43:27 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1694addd2c0b173a6a95ce675b7c38a268eddba4 Cr-Commit-Position: refs/heads/master@{#303408}
6 years, 1 month ago (2014-11-09 21:44:04 UTC) #5
Nico
6 years, 1 month ago (2014-11-09 22:03:56 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698