Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 711853002: Revert of Fix Runtime.executionContextCreated for crafted iframes. (Closed)

Created:
6 years, 1 month ago by dcheng
Modified:
6 years, 1 month ago
CC:
blink-reviews, caseq+blink_chromium.org, Nate Chapin, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, arv+blink, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, tyoshino+watch_chromium.org, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Fix Runtime.executionContextCreated for crafted iframes. (patchset #6 id:100001 of https://codereview.chromium.org/686763002/) Reason for revert: Speculatively reverting to fix telemetry_unittests failures. Original issue's description: > Fix Runtime.executionContextCreated for crafted iframes. > > BUG=331407 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184995 TBR=vsevik@chromium.org,yurys@chromium.org,sergeyv@chromium.org,aandrey@chromium.org,eustas@chromium.org NOTREECHECKS=true NOTRY=true BUG=331407 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184999

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -76 lines) Patch
M LayoutTests/inspector-protocol/runtime/runtime-execution-contexts-events.html View 4 chunks +0 lines, -34 lines 0 comments Download
M LayoutTests/inspector-protocol/runtime/runtime-execution-contexts-events-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/ScriptController.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptController.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/WindowProxy.cpp View 2 chunks +3 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.cpp View 4 chunks +4 lines, -21 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dcheng
Created Revert of Fix Runtime.executionContextCreated for crafted iframes.
6 years, 1 month ago (2014-11-08 03:57:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711853002/1
6 years, 1 month ago (2014-11-08 03:58:15 UTC) #2
commit-bot: I haz the power
6 years, 1 month ago (2014-11-08 03:58:50 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184999

Powered by Google App Engine
This is Rietveld 408576698