Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: runtime/vm/code_patcher_ia32.cc

Issue 711833002: Support verified heap pointer writes on ia32. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/code_patcher_ia32.cc
===================================================================
--- runtime/vm/code_patcher_ia32.cc (revision 41609)
+++ runtime/vm/code_patcher_ia32.cc (working copy)
@@ -9,6 +9,7 @@
#include "vm/code_patcher.h"
#include "vm/cpu.h"
#include "vm/dart_entry.h"
+#include "vm/flow_graph_compiler.h"
#include "vm/instructions.h"
#include "vm/object.h"
#include "vm/raw_object.h"
@@ -275,7 +276,7 @@
class EdgeCounter : public ValueObject {
public:
EdgeCounter(uword pc, const Code& ignored)
- : end_(pc - CodePatcher::EdgeCounterIncrementSizeInBytes()) {
+ : end_(pc - FlowGraphCompiler::EdgeCounterIncrementSizeInBytes()) {
ASSERT(IsValid(end_));
}
@@ -292,14 +293,6 @@
};
-int32_t CodePatcher::EdgeCounterIncrementSizeInBytes() {
- // The edge counter load is followed by the fixed-size edge counter
- // incrementing code:
- // 83 40 0b 02 add [eax+0xb],0x2
- return 4;
-}
-
-
RawObject* CodePatcher::GetEdgeCounterAt(uword pc, const Code& code) {
ASSERT(code.ContainsInstructionAt(pc));
EdgeCounter counter(pc, code);

Powered by Google App Engine
This is Rietveld 408576698