Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Unified Diff: net/filter/mock_filter_context.h

Issue 711753003: Pin dictionaries from being deleted while request is outstanding. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated comments; fixed try job errors. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/filter/mock_filter_context.h
diff --git a/net/filter/mock_filter_context.h b/net/filter/mock_filter_context.h
index 8150e8b2c4be4d24345aa9875e8f942f8786ddeb..8636b8512af47316082fa98a82d529aaf7f8b21f 100644
--- a/net/filter/mock_filter_context.h
+++ b/net/filter/mock_filter_context.h
@@ -8,6 +8,7 @@
#include <string>
#include "base/memory/scoped_ptr.h"
+#include "net/base/sdch_manager.h"
#include "net/filter/filter.h"
#include "url/gurl.h"
@@ -29,8 +30,8 @@ class MockFilterContext : public FilterContext {
void SetCached(bool is_cached) { is_cached_content_ = is_cached; }
void SetDownload(bool is_download) { is_download_ = is_download; }
void SetResponseCode(int response_code) { response_code_ = response_code; }
- void SetSdchResponse(bool is_sdch_response) {
- is_sdch_response_ = is_sdch_response;
+ void SetSdchResponse(scoped_ptr<SdchManager::DictionarySet> handle) {
+ dictionaries_handle_ = handle.Pass();
}
URLRequestContext* GetModifiableURLRequestContext() const {
return context_.get();
@@ -60,8 +61,8 @@ class MockFilterContext : public FilterContext {
// Is this a download?
bool IsDownload() const override;
- // Was this data flagged as a response to a request with an SDCH dictionary?
- bool SdchResponseExpected() const override;
+ // Handle to dictionaries advertised.
+ SdchManager::DictionarySet* SdchDictionariesAdvertised() const override;
// How many bytes were fed to filter(s) so far?
int64 GetByteReadCount() const override;
@@ -81,7 +82,7 @@ class MockFilterContext : public FilterContext {
base::Time request_time_;
bool is_cached_content_;
bool is_download_;
- bool is_sdch_response_;
+ scoped_ptr<SdchManager::DictionarySet> dictionaries_handle_;
bool ok_to_call_get_url_;
int response_code_;
scoped_ptr<URLRequestContext> context_;

Powered by Google App Engine
This is Rietveld 408576698