Pin dictionaries from being deleted while request is outstanding.

net/filter/filter.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // Filter performs filtering on data streams. Sample usage:
 //
 //   IStream* pre_filter_source;
 //   ...
 //   Filter* filter = Filter::Factory(filter_type, size);
 //   int pre_filter_data_len = filter->stream_buffer_size();
@@ skipping 37 matching lines @@
 
 #include <string>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/time/time.h"
 #include "net/base/net_export.h"
+#include "net/base/sdch_manager.h"
 
 class GURL;
 
 namespace net {
 
 class URLRequestContext;
 class IOBuffer;
 
 //------------------------------------------------------------------------------
 // Define an interface class that allows access to contextual information
 // supplied by the owner of this filter.  In the case where there are a chain of
 // filters, there is only one owner of all the chained filters, and that context
 // is passed to the constructor of all those filters.  To be clear, the context
 // does NOT reflect the position in a chain, or the fact that there are prior
 // or later filters in a chain.
+//
+// TODO(rdsmith): FilterContext is a grab-bag of methods which may or may
+// not be relevant for any particular filter, and it's getting worse over
+// time.  In addition, it only supports two filters, sdch and gzip.
+// It would make more sense to implement FilterContext as a
+// base::SupportsUserData structure to which filter-specific information
+// could be added by whatever the ultimate consumer of the filter chain is,
+// and a particular filter (if included) could access that information.
 class NET_EXPORT_PRIVATE FilterContext {
  public:
   // Enum to control what histograms are emitted near end-of-life of this
   // instance.
   enum StatisticSelector {
     SDCH_DECODE,
     SDCH_PASSTHROUGH,
     SDCH_EXPERIMENT_DECODE,
     SDCH_EXPERIMENT_HOLDBACK,
   };
@@ skipping 16 matching lines @@
   // When was this data requested from a server?
   virtual base::Time GetRequestTime() const = 0;
 
   // Is data supplied from cache, or fresh across the net?
   virtual bool IsCachedContent() const = 0;
 
   // Is this a download?
   virtual bool IsDownload() const = 0;
 
   // Was this data flagged as a response to a request with an SDCH dictionary?
-  virtual bool SdchResponseExpected() const = 0;
+  virtual SdchManager::DictionarySet*
+      SdchDictionariesAdvertised() const = 0;

[Bence, 2014/11/12 21:46:26]

From the Google C++ style guide:  "If you break after the return type of a
function declaration or definition, do not indent."

[Randy Smith (Not in Mondays), 2014/11/13 22:11:02]

Moot; fits on one line anyway :-}.  Fixed.

 
   // How many bytes were read from the net or cache so far (and potentially
   // pushed into a filter for processing)?
   virtual int64 GetByteReadCount() const = 0;
 
   // What response code was received with the associated network transaction?
   // For example: 200 is ok.   4xx are error codes. etc.
   virtual int GetResponseCode() const = 0;
 
   // The URLRequestContext associated with the request.
@@ skipping 173 matching lines @@
   // Remember what status or local filter last returned so we can better handle
   // chained filters.
   FilterStatus last_status_;
 
   DISALLOW_COPY_AND_ASSIGN(Filter);
 };
 
 }  // namespace net
 
 #endif  // NET_FILTER_FILTER_H__