Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 711603002: Fix MinidumpMiscInfoWriter test compilation with 32-bit time_t (Closed)

Created:
6 years, 1 month ago by Mark Mentovai
Modified:
6 years, 1 month ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

Fix MinidumpMiscInfoWriter test compilation with 32-bit time_t. This produced errors such as: minidump_misc_info_writer_test.cc:665:32: error: non-constant-expression cannot be narrowed from type 'uint32_t' (aka 'unsigned int') to '__darwin_time_t' (aka 'long') in initializer list [-Wc++11-narrowing] const timeval kStartTime = { expect_misc_info.ProcessCreateTime, 0 }; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ minidump_misc_info_writer_test.cc:665:32: note: override this message by inserting an explicit cast const timeval kStartTime = { expect_misc_info.ProcessCreateTime, 0 }; ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ static_cast<__darwin_time_t>( ) TEST=minidump_test MinidumpMiscInfoWriter.InitializeFromSnapshot R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/408262d58fabff5a10211f23763fc40e9507c772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M minidump/minidump_misc_info_writer_test.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 1 month ago (2014-11-07 00:09:55 UTC) #2
Robert Sesek
LGTM
6 years, 1 month ago (2014-11-07 14:49:42 UTC) #3
Mark Mentovai
6 years, 1 month ago (2014-11-07 15:02:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
408262d58fabff5a10211f23763fc40e9507c772 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698