Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 711553003: Correct typo in form fill environment functions (Closed)

Created:
6 years, 1 month ago by Bo Xu
Modified:
6 years, 1 month ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Correct typo in form fill environment functions Complementary patch for pdfium is in https://codereview.chromium.org/700373006/

Patch Set 1 #

Patch Set 2 : Update DEPS #

Patch Set 3 : Rebase master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
Bo Xu
On 2014/11/06 21:48:30, Bo Xu wrote: > mailto:bo_xu@foxitsoftware.com changed reviewers: > + mailto:thestig@chromium.org Ping :)
6 years, 1 month ago (2014-11-14 22:36:40 UTC) #2
Lei Zhang
lgtm
6 years, 1 month ago (2014-11-14 22:44:42 UTC) #3
Lei Zhang
On 2014/11/14 22:36:40, Bo Xu wrote: > On 2014/11/06 21:48:30, Bo Xu wrote: > > ...
6 years, 1 month ago (2014-11-14 22:45:46 UTC) #4
Bo Xu
On 2014/11/14 22:45:46, Lei Zhang wrote: > On 2014/11/14 22:36:40, Bo Xu wrote: > > ...
6 years, 1 month ago (2014-11-14 22:49:06 UTC) #5
Lei Zhang
On 2014/11/14 22:49:06, Bo Xu wrote: > On 2014/11/14 22:45:46, Lei Zhang wrote: > > ...
6 years, 1 month ago (2014-11-14 22:52:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711553003/1
6 years, 1 month ago (2014-11-15 01:36:25 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/92191) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/81980) win_gpu ...
6 years, 1 month ago (2014-11-15 01:41:56 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711553003/20001
6 years, 1 month ago (2014-11-15 07:32:40 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32 on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32/builds/8771) ios_rel_device on tryserver.chromium.mac () mac_chromium_compile_dbg ...
6 years, 1 month ago (2014-11-15 07:34:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711553003/40001
6 years, 1 month ago (2014-11-15 08:07:29 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-11-15 08:10:38 UTC) #20
Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_gn_rel on tryserver.chromium.linux ()

Powered by Google App Engine
This is Rietveld 408576698