|
|
DescriptionCorrect typo in form fill environment functions
Complementary patch for pdfium is in https://codereview.chromium.org/700373006/
Patch Set 1 #Patch Set 2 : Update DEPS #Patch Set 3 : Rebase master #Messages
Total messages: 20 (9 generated)
bo_xu@foxitsoftware.com changed reviewers: + thestig@chromium.org
On 2014/11/06 21:48:30, Bo Xu wrote: > mailto:bo_xu@foxitsoftware.com changed reviewers: > + mailto:thestig@chromium.org Ping :)
lgtm
On 2014/11/14 22:36:40, Bo Xu wrote: > On 2014/11/06 21:48:30, Bo Xu wrote: > > mailto:bo_xu@foxitsoftware.com changed reviewers: > > + mailto:thestig@chromium.org > > Ping :) Notice this is the first message for this CL. If you uploaded this last week, I didn't see it because I never received an email.
On 2014/11/14 22:45:46, Lei Zhang wrote: > On 2014/11/14 22:36:40, Bo Xu wrote: > > On 2014/11/06 21:48:30, Bo Xu wrote: > > > mailto:bo_xu@foxitsoftware.com changed reviewers: > > > + mailto:thestig@chromium.org > > > > Ping :) > > Notice this is the first message for this CL. If you uploaded this last week, I > didn't see it because I never received an email. I see. So "Edit Issue" button does not send email.
The CQ bit was checked by bo_xu@foxitsoftware.com
The CQ bit was unchecked by bo_xu@foxitsoftware.com
On 2014/11/14 22:49:06, Bo Xu wrote: > On 2014/11/14 22:45:46, Lei Zhang wrote: > > On 2014/11/14 22:36:40, Bo Xu wrote: > > > On 2014/11/06 21:48:30, Bo Xu wrote: > > > > mailto:bo_xu@foxitsoftware.com changed reviewers: > > > > + mailto:thestig@chromium.org > > > > > > Ping :) > > > > Notice this is the first message for this CL. If you uploaded this last week, > I > > didn't see it because I never received an email. > > I see. So "Edit Issue" button does not send email. Correct. I've made the same mistake a few times too.
The CQ bit was checked by bo_xu@foxitsoftware.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711553003/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/81980) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/86867) android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...) android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...) android_chromium_gn_compile_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...) chromium_presubmit on tryserver.chromium.linux () linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_32 on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...) ios_rel_device on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...) win_chromium_compile_dbg on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel/...) win_chromium_x64_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by bo_xu@foxitsoftware.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711553003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_32 on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios_rel_device on tryserver.chromium.mac () mac_chromium_compile_dbg on tryserver.chromium.mac () mac_chromium_rel_ng on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win8_chromium_rel on tryserver.chromium.win () win_chromium_x64_rel on tryserver.chromium.win ()
The CQ bit was checked by bo_xu@foxitsoftware.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711553003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_gn_rel on tryserver.chromium.linux () |