Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: src/runtime.js

Issue 71153004: Ensure that ToPositiveInteger is optimizable. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 647 matching lines...) Expand 10 before | Expand all | Expand 10 after
658 if (IS_SPEC_FUNCTION(valueOf)) { 658 if (IS_SPEC_FUNCTION(valueOf)) {
659 var v = %_CallFunction(x, valueOf); 659 var v = %_CallFunction(x, valueOf);
660 if (%IsPrimitive(v)) return v; 660 if (%IsPrimitive(v)) return v;
661 } 661 }
662 662
663 throw %MakeTypeError('cannot_convert_to_primitive', []); 663 throw %MakeTypeError('cannot_convert_to_primitive', []);
664 } 664 }
665 665
666 function ToPositiveInteger(x, rangeErrorName) { 666 function ToPositiveInteger(x, rangeErrorName) {
667 var i = TO_INTEGER(x); 667 var i = TO_INTEGER(x);
668 if (i < 0) throw %MakeRangeError(rangeErrorName); 668 if (i < 0) throw MakeRangeError(rangeErrorName);
669 return i; 669 return i;
670 } 670 }
671 671
672 672
673 // NOTE: Setting the prototype for Array must take place as early as 673 // NOTE: Setting the prototype for Array must take place as early as
674 // possible due to code generation for array literals. When 674 // possible due to code generation for array literals. When
675 // generating code for a array literal a boilerplate array is created 675 // generating code for a array literal a boilerplate array is created
676 // that is cloned when running the code. It is essential that the 676 // that is cloned when running the code. It is essential that the
677 // boilerplate gets the right prototype. 677 // boilerplate gets the right prototype.
678 %FunctionSetPrototype($Array, new $Array(0)); 678 %FunctionSetPrototype($Array, new $Array(0));
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698