Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 71153004: Ensure that ToPositiveInteger is optimizable. (Closed)

Created:
7 years, 1 month ago by Dmitry Lomov (no reviews)
Modified:
7 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Ensure that ToPositiveInteger is optimizable. 'throw %NAME(..)' cause hydrogen optimizations to be disabled for surrounding function. This patch rectifies. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/runtime.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Dmitry Lomov (no reviews)
PTAL. Gives some speedup for typed arrays and friends
7 years, 1 month ago (2013-11-13 15:34:27 UTC) #1
Dmitry Lomov (no reviews)
On 2013/11/13 15:34:27, Dmitry Lomov (chromium) wrote: > PTAL. Gives some speedup for typed arrays ...
7 years, 1 month ago (2013-11-15 18:20:02 UTC) #2
Yang
On 2013/11/15 18:20:02, Dmitry Lomov (chromium) wrote: > On 2013/11/13 15:34:27, Dmitry Lomov (chromium) wrote: ...
7 years, 1 month ago (2013-11-18 08:53:03 UTC) #3
Yang
On 2013/11/18 08:53:03, Yang wrote: > On 2013/11/15 18:20:02, Dmitry Lomov (chromium) wrote: > > ...
7 years, 1 month ago (2013-11-18 08:53:41 UTC) #4
Dmitry Lomov (no reviews)
On 2013/11/18 08:53:03, Yang wrote: > On 2013/11/15 18:20:02, Dmitry Lomov (chromium) wrote: > > ...
7 years, 1 month ago (2013-11-18 08:56:57 UTC) #5
Dmitry Lomov (no reviews)
7 years, 1 month ago (2013-11-18 14:07:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r17832 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698