sky/engine/core/frame/FrameConsole.cpp - Issue 711513003: Make import failures log errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/frame/FrameConsole.cpp

Issue 711513003: Make import failures log errors (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: rebase observe-attributes Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/frame/FrameConsole.cpp

diff --git a/sky/engine/core/frame/FrameConsole.cpp b/sky/engine/core/frame/FrameConsole.cpp

index f619702a7c7e3c614787a7bf218af1f1ef0d92d8..ce351e577b35001b25df84b9bcba314c4e7a8ded 100644

--- a/sky/engine/core/frame/FrameConsole.cpp

+++ b/sky/engine/core/frame/FrameConsole.cpp

@@ -96,9 +96,6 @@ void FrameConsole::addMessage(PassRefPtr<ConsoleMessage> prpConsoleMessage)

messageStorage()->reportMessage(consoleMessage);

- if (consoleMessage->source() == CSSMessageSource || consoleMessage->source() == NetworkMessageSource)

- return;

RefPtr<ScriptCallStack> reportedCallStack = nullptr;

if (consoleMessage->source() != ConsoleAPIMessageSource) {

if (consoleMessage->callStack() && m_frame.chromeClient().shouldReportDetailedMessageForSource(messageURL))

« no previous file with comments | « no previous file | sky/engine/core/html/imports/HTMLImportLoader.cpp » ('j') | no next file with comments »