Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Side by Side Diff: Source/core/rendering/svg/RenderSVGContainer.cpp

Issue 711493004: Remove unnecessary paintContainer parameter from addFocusRingRects (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005, 2007 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2007, 2008 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2007, 2008 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Google, Inc. All rights reserved. 5 * Copyright (C) 2009 Google, Inc. All rights reserved.
6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org> 6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 SVGResources* resources = SVGResourcesCache::cachedResourcesForRenderObject( this); 97 SVGResources* resources = SVGResourcesCache::cachedResourcesForRenderObject( this);
98 return resources && resources->filter(); 98 return resources && resources->filter();
99 } 99 }
100 100
101 void RenderSVGContainer::paint(PaintInfo& paintInfo, const LayoutPoint&) 101 void RenderSVGContainer::paint(PaintInfo& paintInfo, const LayoutPoint&)
102 { 102 {
103 SVGContainerPainter(*this).paint(paintInfo); 103 SVGContainerPainter(*this).paint(paintInfo);
104 } 104 }
105 105
106 // addFocusRingRects is called from paintOutline and needs to be in the same coo rdinates as the paintOuline call 106 // addFocusRingRects is called from paintOutline and needs to be in the same coo rdinates as the paintOuline call
107 void RenderSVGContainer::addFocusRingRects(Vector<LayoutRect>& rects, const Layo utPoint&, const RenderLayerModelObject*) const 107 void RenderSVGContainer::addFocusRingRects(Vector<LayoutRect>& rects, const Layo utPoint&) const
108 { 108 {
109 LayoutRect paintRectInParent = LayoutRect(localToParentTransform().mapRect(p aintInvalidationRectInLocalCoordinates())); 109 LayoutRect paintRectInParent = LayoutRect(localToParentTransform().mapRect(p aintInvalidationRectInLocalCoordinates()));
110 if (!paintRectInParent.isEmpty()) 110 if (!paintRectInParent.isEmpty())
111 rects.append(paintRectInParent); 111 rects.append(paintRectInParent);
112 } 112 }
113 113
114 void RenderSVGContainer::updateCachedBoundaries() 114 void RenderSVGContainer::updateCachedBoundaries()
115 { 115 {
116 SVGRenderSupport::computeContainerBoundingBoxes(this, m_objectBoundingBox, m _objectBoundingBoxValid, m_strokeBoundingBox, m_paintInvalidationBoundingBox); 116 SVGRenderSupport::computeContainerBoundingBoxes(this, m_objectBoundingBox, m _objectBoundingBoxValid, m_strokeBoundingBox, m_paintInvalidationBoundingBox);
117 SVGRenderSupport::intersectPaintInvalidationRectWithResources(this, m_paintI nvalidationBoundingBox); 117 SVGRenderSupport::intersectPaintInvalidationRectWithResources(this, m_paintI nvalidationBoundingBox);
(...skipping 22 matching lines...) Expand all
140 if (objectBoundingBox().contains(localPoint)) { 140 if (objectBoundingBox().contains(localPoint)) {
141 updateHitTestResult(result, roundedLayoutPoint(localPoint)); 141 updateHitTestResult(result, roundedLayoutPoint(localPoint));
142 return true; 142 return true;
143 } 143 }
144 } 144 }
145 // 16.4: "If there are no graphics elements whose relevant graphics content is under the pointer (i.e., there is no target element), the event is not dispat ched." 145 // 16.4: "If there are no graphics elements whose relevant graphics content is under the pointer (i.e., there is no target element), the event is not dispat ched."
146 return false; 146 return false;
147 } 147 }
148 148
149 } 149 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698