Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Side by Side Diff: Source/core/rendering/RenderTextControl.h

Issue 711493004: Remove unnecessary paintContainer parameter from addFocusRingRects (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
3 * (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 3 * (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 private: 74 private:
75 virtual const char* renderName() const override { return "RenderTextControl" ; } 75 virtual const char* renderName() const override { return "RenderTextControl" ; }
76 virtual void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, Layo utUnit& maxLogicalWidth) const override final; 76 virtual void computeIntrinsicLogicalWidths(LayoutUnit& minLogicalWidth, Layo utUnit& maxLogicalWidth) const override final;
77 virtual void computePreferredLogicalWidths() override final; 77 virtual void computePreferredLogicalWidths() override final;
78 virtual void removeLeftoverAnonymousBlock(RenderBlock*) override final { } 78 virtual void removeLeftoverAnonymousBlock(RenderBlock*) override final { }
79 virtual bool avoidsFloats() const override final { return true; } 79 virtual bool avoidsFloats() const override final { return true; }
80 virtual bool canHaveGeneratedChildren() const override final { return false; } 80 virtual bool canHaveGeneratedChildren() const override final { return false; }
81 81
82 virtual void addChild(RenderObject* newChild, RenderObject* beforeChild = 0) override final; 82 virtual void addChild(RenderObject* newChild, RenderObject* beforeChild = 0) override final;
83 83
84 virtual void addFocusRingRects(Vector<LayoutRect>&, const LayoutPoint& addit ionalOffset, const RenderLayerModelObject* paintContainer) const override final; 84 virtual void addFocusRingRects(Vector<LayoutRect>&, const LayoutPoint& addit ionalOffset) const override final;
85 85
86 virtual bool canBeProgramaticallyScrolled() const override final { return tr ue; } 86 virtual bool canBeProgramaticallyScrolled() const override final { return tr ue; }
87 }; 87 };
88 88
89 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderTextControl, isTextControl()); 89 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderTextControl, isTextControl());
90 90
91 // Renderer for our inner container, for <search> and others. 91 // Renderer for our inner container, for <search> and others.
92 // We can't use RenderFlexibleBox directly, because flexboxes have a different 92 // We can't use RenderFlexibleBox directly, because flexboxes have a different
93 // baseline definition, and then inputs of different types wouldn't line up 93 // baseline definition, and then inputs of different types wouldn't line up
94 // anymore. 94 // anymore.
95 class RenderTextControlInnerContainer final : public RenderFlexibleBox { 95 class RenderTextControlInnerContainer final : public RenderFlexibleBox {
96 public: 96 public:
97 explicit RenderTextControlInnerContainer(Element* element) 97 explicit RenderTextControlInnerContainer(Element* element)
98 : RenderFlexibleBox(element) 98 : RenderFlexibleBox(element)
99 { } 99 { }
100 virtual ~RenderTextControlInnerContainer() { } 100 virtual ~RenderTextControlInnerContainer() { }
101 101
102 virtual int baselinePosition(FontBaseline baseline, bool firstLine, LineDire ctionMode direction, LinePositionMode position) const override 102 virtual int baselinePosition(FontBaseline baseline, bool firstLine, LineDire ctionMode direction, LinePositionMode position) const override
103 { 103 {
104 return RenderBlock::baselinePosition(baseline, firstLine, direction, pos ition); 104 return RenderBlock::baselinePosition(baseline, firstLine, direction, pos ition);
105 } 105 }
106 virtual int firstLineBoxBaseline() const override { return RenderBlock::firs tLineBoxBaseline(); } 106 virtual int firstLineBoxBaseline() const override { return RenderBlock::firs tLineBoxBaseline(); }
107 virtual int inlineBlockBaseline(LineDirectionMode direction) const override { return lastLineBoxBaseline(direction); } 107 virtual int inlineBlockBaseline(LineDirectionMode direction) const override { return lastLineBoxBaseline(direction); }
108 }; 108 };
109 109
110 110
111 } // namespace blink 111 } // namespace blink
112 112
113 #endif // RenderTextControl_h 113 #endif // RenderTextControl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698