Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 711473003: Remove more testing of getPropertyCSSValue (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove more testing of getPropertyCSSValue As getPropertyCSSValue, CSSValue, CSSValueList, CSSPrimitiveValue, Counter, RGBColor and Rect are no longer web-exposed, we should stop testing them so we can delete the interface. BUG=428595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184975

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -119 lines) Patch
M LayoutTests/css3/calc/reflection-computed-style.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/css3/calc/reflection-computed-style-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/get-set-properties.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/get-set-properties-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/resources/window-properties.js View 2 chunks +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-lookup-precedence-expected.txt View 3 chunks +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-property-shadowing.html View 2 chunks +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-property-shadowing-expected.txt View 2 chunks +0 lines, -5 lines 0 comments Download
M LayoutTests/fast/dom/constants.html View 3 chunks +2 lines, -13 lines 0 comments Download
M LayoutTests/fast/dom/constants-expected.txt View 2 chunks +1 line, -9 lines 0 comments Download
M LayoutTests/fast/dom/dom-constructors.html View 3 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/dom-constructors-expected.txt View 3 chunks +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/dom/domListEnumeration-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M LayoutTests/fast/dom/resources/wrapper-identity-base.js View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/script-tests/domListEnumeration.js View 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/fast/dom/wrapper-classes.html View 3 chunks +0 lines, -9 lines 0 comments Download
M LayoutTests/fast/dom/wrapper-classes-expected.txt View 1 chunk +0 lines, -20 lines 0 comments Download
M LayoutTests/fast/dom/wrapper-identity-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
6 years, 1 month ago (2014-11-06 19:39:21 UTC) #2
alancutter (OOO until 2018)
lgtm
6 years, 1 month ago (2014-11-07 04:18:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711473003/1
6 years, 1 month ago (2014-11-07 16:14:32 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 16:16:56 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 184975

Powered by Google App Engine
This is Rietveld 408576698