Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: Source/core/rendering/svg/RenderSVGModelObject.cpp

Issue 711453004: absoluteFocusRingQuads() => absoluteFocusRingBoundingBoxRect() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/svg/RenderSVGModelObject.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2009, Google Inc. All rights reserved. 2 * Copyright (c) 2009, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 RenderObject::styleDidChange(diff, oldStyle); 111 RenderObject::styleDidChange(diff, oldStyle);
112 SVGResourcesCache::clientStyleChanged(this, diff, style()); 112 SVGResourcesCache::clientStyleChanged(this, diff, style());
113 } 113 }
114 114
115 bool RenderSVGModelObject::nodeAtPoint(const HitTestRequest&, HitTestResult&, co nst HitTestLocation&, const LayoutPoint&, HitTestAction) 115 bool RenderSVGModelObject::nodeAtPoint(const HitTestRequest&, HitTestResult&, co nst HitTestLocation&, const LayoutPoint&, HitTestAction)
116 { 116 {
117 ASSERT_NOT_REACHED(); 117 ASSERT_NOT_REACHED();
118 return false; 118 return false;
119 } 119 }
120 120
121 // The SVG addFocusRingRects() method adds rects in local coordinates so the def ault absoluteFocusRingQuads 121 // The SVG addFocusRingRects() method adds rects in local coordinates so the def ault absoluteFocusRingBoundingBoxRect
122 // returns incorrect values for SVG objects. Overriding this method provides acc ess to the absolute bounds. 122 // returns incorrect values for SVG objects. Overriding this method provides acc ess to the absolute bounds.
123 void RenderSVGModelObject::absoluteFocusRingQuads(Vector<FloatQuad>& quads) 123 IntRect RenderSVGModelObject::absoluteFocusRingBoundingBoxRect() const
124 { 124 {
125 quads.append(localToAbsoluteQuad(FloatQuad(paintInvalidationRectInLocalCoord inates()))); 125 return localToAbsoluteQuad(FloatQuad(paintInvalidationRectInLocalCoordinates ())).enclosingBoundingBox();
126 } 126 }
127 127
128 void RenderSVGModelObject::invalidateTreeIfNeeded(const PaintInvalidationState& paintInvalidationState) 128 void RenderSVGModelObject::invalidateTreeIfNeeded(const PaintInvalidationState& paintInvalidationState)
129 { 129 {
130 ASSERT(!needsLayout()); 130 ASSERT(!needsLayout());
131 131
132 // If we didn't need paint invalidation then our children don't need as well . 132 // If we didn't need paint invalidation then our children don't need as well .
133 // Skip walking down the tree as everything should be fine below us. 133 // Skip walking down the tree as everything should be fine below us.
134 if (!shouldCheckForPaintInvalidation(paintInvalidationState)) 134 if (!shouldCheckForPaintInvalidation(paintInvalidationState))
135 return; 135 return;
136 136
137 invalidatePaintIfNeeded(paintInvalidationState, paintInvalidationState.paint InvalidationContainer()); 137 invalidatePaintIfNeeded(paintInvalidationState, paintInvalidationState.paint InvalidationContainer());
138 clearPaintInvalidationState(paintInvalidationState); 138 clearPaintInvalidationState(paintInvalidationState);
139 139
140 PaintInvalidationState childPaintInvalidationState(paintInvalidationState, * this); 140 PaintInvalidationState childPaintInvalidationState(paintInvalidationState, * this);
141 invalidatePaintOfSubtreesIfNeeded(childPaintInvalidationState); 141 invalidatePaintOfSubtreesIfNeeded(childPaintInvalidationState);
142 } 142 }
143 143
144 } // namespace blink 144 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/svg/RenderSVGModelObject.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698