Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: Source/devtools/front_end/timeline/LayerDetailsView.js

Issue 711423002: DevTools: better visual feedback for hovered objects is Layers3DView (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: addressed review comments, fixed test Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/LayerDetailsView.js
diff --git a/Source/devtools/front_end/timeline/LayerDetailsView.js b/Source/devtools/front_end/timeline/LayerDetailsView.js
index 8c8fe1272c0b541d992b7daf6619033253d5260e..05c613dacc56ca37f11843e22ab4e4533ff5a65d 100644
--- a/Source/devtools/front_end/timeline/LayerDetailsView.js
+++ b/Source/devtools/front_end/timeline/LayerDetailsView.js
@@ -88,12 +88,12 @@ WebInspector.LayerDetailsView.CompositingReasonDetail = {
WebInspector.LayerDetailsView.prototype = {
/**
- * @param {?WebInspector.Layers3DView.ActiveObject} activeObject
+ * @param {?WebInspector.Layers3DView.Selection} selection
*/
- setObject: function(activeObject)
+ setObject: function(selection)
{
- this._layer = activeObject ? activeObject.layer : null;
- this._scrollRectIndex = activeObject ? activeObject.scrollRectIndex : null;
+ this._layer = selection ? selection.layer : null;
+ this._scrollRectIndex = selection ? selection.scrollRectIndex : null;
if (this.isShowing())
this.update();
},
@@ -112,7 +112,7 @@ WebInspector.LayerDetailsView.prototype = {
{
if (event.which !== 1)
return;
- this.dispatchEventToListeners(WebInspector.LayerDetailsView.Events.ObjectSelected, {layer: this._layer, scrollRectIndex: index});
+ this.dispatchEventToListeners(WebInspector.LayerDetailsView.Events.ObjectSelected, new WebInspector.Layers3DView.ScrollRectSelection(this._layer, index));
},
/**
« no previous file with comments | « Source/devtools/front_end/layers/LayersPanel.js ('k') | Source/devtools/front_end/timeline/LayerTreeOutline.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698