Issue 711343003: [Merge] Cancel uninstall if the uninstall dialog's parent window is destroyed prior to the uninstal…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 711343003: [Merge] Cancel uninstall if the uninstall dialog's parent window is destroyed prior to the uninstal… (Closed)

Created:
6 years, 1 month ago by pkotwicz

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2171

Project:
chromium

Visibility:
Public.

[Merge] Cancel uninstall if the uninstall dialog's parent window is destroyed prior to the uninstall dialog showing. BUG=424999, 397396 TEST=ExtensionUninstallDialogViewBrowserTest.TrackParentWindowDestruction TBR=pkotwicz Review URL: https://codereview.chromium.org/697023002 Committed: https://chromium.googlesource.com/chromium/src/+/6919459fb7f674aaf05277ebe2fe12e746d4a3f9

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+100 lines, -19 lines)			Patch
M	chrome/browser/extensions/extension_uninstall_dialog.h	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	chrome/browser/extensions/extension_uninstall_dialog.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_uninstall_dialog_cocoa.mm	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc	View	5 chunks	+19 lines, -4 lines	0 comments	Download
A	chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc	View	1 chunk	+76 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 1 (0 generated)

pkotwicz

6 years, 1 month ago (2014-11-11 16:48:32 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6919459fb7f674aaf05277ebe2fe12e746d4a3f9 (presubmit successful).