Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 711343002: Exclude unused functions for NaCl code path. (Closed)

Created:
6 years, 1 month ago by mazda
Modified:
6 years, 1 month ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Exclude unused functions for NaCl code path. An upcoming NaCl roll is going to update arm-nacl-gcc from 4.8.3 to version 4.9.2. When -Wunused-function is specified, gcc 4.8.3 only warns unused static functions. On the other hand, gcc 4.9.2 warns unused functions in anonymous namespace in addition to the unused static functions. This change would cause compile errors because there are a few unused functions in anonymous namespace. This CL fixes the compile errors of ARM build that the upcoming NaCl roll would cause. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3887 TEST=Locally update NaCl revision and ARM build succeeds. Committed: https://crrev.com/9cfbcfb3e00697d3663a5dbf4fd8c81ae6970d97 Cr-Commit-Position: refs/heads/master@{#303847}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M base/message_loop/message_loop.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M base/threading/platform_thread_linux.cc View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.cc View 3 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (2 generated)
mazda
PTAL thestig, Please do an OWNERS review for base/. teravest, Please do an OWNERS review ...
6 years, 1 month ago (2014-11-12 04:24:33 UTC) #2
Lei Zhang
lgtm
6 years, 1 month ago (2014-11-12 05:31:47 UTC) #3
Mark Seaborn
LGTM
6 years, 1 month ago (2014-11-12 05:35:05 UTC) #4
teravest
lgtm
6 years, 1 month ago (2014-11-12 15:32:33 UTC) #5
mazda
Thank you all for the review. Will submit.
6 years, 1 month ago (2014-11-12 15:48:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711343002/60001
6 years, 1 month ago (2014-11-12 15:49:18 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-11-12 17:07:21 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-12 17:08:08 UTC) #10
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9cfbcfb3e00697d3663a5dbf4fd8c81ae6970d97
Cr-Commit-Position: refs/heads/master@{#303847}

Powered by Google App Engine
This is Rietveld 408576698