Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1674)

Unified Diff: components/autofill/core/common/password_form.h

Issue 711333002: [Password Manager] Correct the documentation within PasswordFormFillData struct for form origin and… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated nits. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/autofill/core/common/password_form_fill_data.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/common/password_form.h
diff --git a/components/autofill/core/common/password_form.h b/components/autofill/core/common/password_form.h
index becf0b28f3ec4a8c8309be87392f04b93429ecb3..77051bb8aa58326881c928d63d5e0c896c46bcbf 100644
--- a/components/autofill/core/common/password_form.h
+++ b/components/autofill/core/common/password_form.h
@@ -73,20 +73,21 @@ struct PasswordForm {
// http://www.example.com.
std::string original_signon_realm;
- // The URL (minus query parameters) containing the form. This is the primary
- // data used by the PasswordManager to decide (in longest matching prefix
- // fashion) whether or not a given PasswordForm result from the database is a
- // good fit for a particular form on a page, so it must not be empty.
+ // An origin URL consists of the scheme, host, port and path; the rest is
+ // stripped. This is the primary data used by the PasswordManager to decide
+ // (in longest matching prefix fashion) whether or not a given PasswordForm
+ // result from the database is a good fit for a particular form on a page, so
+ // it must not be empty.
GURL origin;
- // The action target of the form. This is the primary data used by the
- // PasswordManager for form autofill; that is, the action of the saved
+ // The action target of the form; like |origin| URL consists of the scheme,
+ // host, port and path; the rest is stripped. This is the primary data used by
+ // the PasswordManager for form autofill; that is, the action of the saved
// credentials must match the action of the form on the page to be autofilled.
- // If this is empty / not available, it will result in a "restricted"
- // IE-like autofill policy, where we wait for the user to type in his
- // username before autofilling the password. In these cases, after successful
- // login the action URL will automatically be assigned by the
- // PasswordManager.
+ // If this is empty / not available, it will result in a "restricted" IE-like
+ // autofill policy, where we wait for the user to type in his username before
+ // autofilling the password. In these cases, after successful login the action
+ // URL will automatically be assigned by the PasswordManager.
//
// When parsing an HTML form, this must always be set.
GURL action;
« no previous file with comments | « no previous file | components/autofill/core/common/password_form_fill_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698