Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 711333002: [Password Manager] Correct the documentation within PasswordFormFillData struct for form origin and… (Closed)

Created:
6 years, 1 month ago by Pritam Nikam
Modified:
6 years, 1 month ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, benquan, wjia+watch_chromium.org, browser-components-watch_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, gcasto+watchlist_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Password Manager] Correct the documentation within PasswordFormFillData struct for form origin and action. It's a follow-up CL to: https://codereview.chromium.org/614023002/ BUG=417295 Committed: https://crrev.com/6c48e440419da5a73344d1010cf33029e173dd1d Cr-Commit-Position: refs/heads/master@{#303635}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Incorporated nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M components/autofill/core/common/password_form.h View 1 1 chunk +12 lines, -11 lines 0 comments Download
M components/autofill/core/common/password_form_fill_data.h View 1 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Pritam Nikam
Hi Vaclav, PTAL! Thanks!
6 years, 1 month ago (2014-11-11 10:20:41 UTC) #2
vabr (Chromium)
Thanks, Pritam Nikam. Some comments: (1) Please include bug 417295 in the CL description. (2) ...
6 years, 1 month ago (2014-11-11 10:35:03 UTC) #3
Pritam Nikam
Thanks Vaclav, I've incorporated nits & modified documentation for PasswordForm::origin & action. PTAL! Thanks! https://codereview.chromium.org/711333002/diff/1/components/autofill/core/common/password_form_fill_data.h ...
6 years, 1 month ago (2014-11-11 10:47:04 UTC) #4
vabr (Chromium)
LGTM, thank you! Vaclav
6 years, 1 month ago (2014-11-11 12:25:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711333002/20001
6 years, 1 month ago (2014-11-11 12:27:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-11 13:15:36 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 13:16:51 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6c48e440419da5a73344d1010cf33029e173dd1d
Cr-Commit-Position: refs/heads/master@{#303635}

Powered by Google App Engine
This is Rietveld 408576698