Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 711313002: Reland "In-object double fields unboxing (for 64-bit only)." (Closed)

Created:
6 years, 1 month ago by Igor Sheludko
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Reland "In-object double fields unboxing (for 64-bit only)." R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25258

Patch Set 1 : Original CL #

Patch Set 2 : The fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1854 lines, -216 lines) Patch
M BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm64/lithium-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 5 chunks +11 lines, -5 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M src/code-stubs-hydrogen.cc View 2 chunks +28 lines, -25 lines 0 comments Download
M src/field-index.h View 3 chunks +4 lines, -2 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/globals.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 4 chunks +30 lines, -3 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +12 lines, -1 line 0 comments Download
M src/heap/objects-visiting.h View 6 chunks +58 lines, -13 lines 0 comments Download
M src/heap/objects-visiting.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +27 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 4 chunks +22 lines, -9 lines 0 comments Download
M src/hydrogen-instructions.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/json-stringifier.h View 1 chunk +9 lines, -2 lines 0 comments Download
A src/layout-descriptor.h View 1 chunk +126 lines, -0 lines 0 comments Download
A src/layout-descriptor.cc View 1 1 chunk +147 lines, -0 lines 0 comments Download
A src/layout-descriptor-inl.h View 1 chunk +185 lines, -0 lines 0 comments Download
M src/objects.h View 1 10 chunks +49 lines, -15 lines 0 comments Download
M src/objects.cc View 1 32 chunks +206 lines, -102 lines 0 comments Download
M src/objects-debug.cc View 4 chunks +28 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 13 chunks +133 lines, -6 lines 0 comments Download
M src/objects-printer.cc View 1 3 chunks +46 lines, -2 lines 0 comments Download
M src/property-details.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/string-stream.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +11 lines, -2 lines 0 comments Download
A test/cctest/test-unboxed-doubles.cc View 1 chunk +668 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Igor Sheludko
PTAL. The problem was that it is not actually allowed to call layout_descriptor() when double ...
6 years, 1 month ago (2014-11-11 09:53:37 UTC) #2
Toon Verwaest
lgtm
6 years, 1 month ago (2014-11-11 10:17:38 UTC) #3
Igor Sheludko
6 years, 1 month ago (2014-11-11 10:25:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 25258 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698