Instrumented libraries: rewrite install-build-deps.sh.

third_party/instrumented_libraries/install-build-deps.sh

Index: third_party/instrumented_libraries/install-build-deps.sh
diff --git a/third_party/instrumented_libraries/install-build-deps.sh b/third_party/instrumented_libraries/install-build-deps.sh
index d86db48c5309767e2a4f8741cce8122bd1c206e9..3bc28bb77ce1fe912ab2a9db67b6e8689c6416ff 100755
--- a/third_party/instrumented_libraries/install-build-deps.sh
+++ b/third_party/instrumented_libraries/install-build-deps.sh
@@ -4,12 +4,73 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-# Script to install build dependencies of packages which we instrument. 
+# Script to install build dependencies of packages which we instrument.
 
-grep \'\<\(\_sanitizer_type \
-     $(dirname ${BASH_SOURCE[0]})/instrumented_libraries.gyp | \
-     sed "s;\s*'<(_sanitizer_type)-\(.*\)',;\1;" | sort | uniq | \
-     xargs sudo apt-get build-dep -y
+common_packages="\
+atk1.0 \
+dee \

[Alexander Potapenko, 2014/11/11 14:41:02]

I don't really like the idea of duplicating this list. I think it could be
better done by:
1. Getting the list of packages from instrumented_libraries.gyp with grep
2. Querying APT for the list of packages that actually exist on the system (I
think `dpkg -l` is a proper tool for this)
3. Installing the build deps for only the existing packages using `apt-get
build-dep`

I agree this stuff may go away with a switch to GN, but since it's being late I
suggest to at least add a todo to get rid of this duplication.

+freetype \
+libappindicator1 \
+libasound2 \
+libcairo2 \
+libcap2 \
+libcups2 \
+libdbus-1-3 \
+libdbus-glib-1-2 \
+libdbusmenu \
+libdbusmenu-glib4 \
+libexpat1 \
+libffi6 \
+libfontconfig1 \
+libgconf-2-4 \
+libgcrypt11 \
+libgdk-pixbuf2.0-0 \
+libglib2.0-0 \
+libgnome-keyring0 \
+libgpg-error0 \
+libgtk2.0-0 \
+libnspr4 \
+libp11-kit0 \
+libpci3 \
+libpcre3 \
+libpixman-1-0 \
+libpng12-0 \
+libunity9 \
+libx11-6 \
+libxau6 \
+libxcb1 \
+libxcomposite1 \
+libxcursor1 \
+libxdamage1 \
+libxdmcp6 \
+libxext6 \
+libxfixes3 \
+libxi6 \
+libxinerama1 \
+libxrandr2 \
+libxrender1 \
+libxss1 \
+libxtst6 \
+nss \
+overlay-scrollbar \
+pango1.0 \
+pulseaudio \
+udev \
+zlib1g"
+
+precise_specific_packages="libtasn1-3"
+trusty_specific_packages="libtasn1-6"
+
+ubuntu_release=$(lsb_release -cs)
+
+if test "$ubuntu_release" = "precise" ; then
+  packages="$common_packages $precise_specific_packages"
+else
+  packages="$common_packages $trusty_specific_packages"
+fi
+
+echo $packages
+sudo apt-get build-dep -y $packages
 
 # Extra build deps for pulseaudio, which apt-get build-dep may fail to install
 # for reasons which are not entirely clear.