Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 711283003: Instrumented libraries: rewrite install-build-deps.sh. (Closed)

Created:
6 years, 1 month ago by earthdok
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Instrumented libraries: rewrite install-build-deps.sh. Explicitly list the packages for which we need to install build dependencies. The grep-based approach no longer works since we now have packages which are specific to a certain Ubuntu release. BUG=414189 R=glider@chromium.org NOTRY=true Committed: https://crrev.com/38a6203a3274f3ec07fe5af8f1c6f35aed8a2785 Cr-Commit-Position: refs/heads/master@{#303646}

Patch Set 1 #

Total comments: 1

Patch Set 2 : todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -5 lines) Patch
M third_party/instrumented_libraries/install-build-deps.sh View 1 1 chunk +67 lines, -5 lines 0 comments Download
M third_party/instrumented_libraries/instrumented_libraries.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
earthdok
6 years, 1 month ago (2014-11-11 14:10:56 UTC) #1
Alexander Potapenko
LGTM https://codereview.chromium.org/711283003/diff/1/third_party/instrumented_libraries/install-build-deps.sh File third_party/instrumented_libraries/install-build-deps.sh (right): https://codereview.chromium.org/711283003/diff/1/third_party/instrumented_libraries/install-build-deps.sh#newcode11 third_party/instrumented_libraries/install-build-deps.sh:11: dee \ I don't really like the idea ...
6 years, 1 month ago (2014-11-11 14:41:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/711283003/20001
6 years, 1 month ago (2014-11-11 14:46:19 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-11 14:46:51 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 14:47:37 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/38a6203a3274f3ec07fe5af8f1c6f35aed8a2785
Cr-Commit-Position: refs/heads/master@{#303646}

Powered by Google App Engine
This is Rietveld 408576698