Fix virtual keyboard overscroll on Athena

Fix virtual keyboard overscroll on Athena

This CL:
- Removes GetFrameWindow() from KeyboardController because the function is not
  compatible with Athena
- Avoids showing the keyboard container after creating it. This was causing
  the insets not to be set on the RenderWidgetHostViews the first time that the
  keyboard is shown

BUG=431798
TEST=None

Committed: https://crrev.com/8f42251c2e197c8eccf58c9517d2b97921d4d083
Cr-Commit-Position: refs/heads/master@{#303888}

[pkotwicz, 2014-11-12 05:54:14]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2014-11-12 05:54:19]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2014-11-12 05:55:06]

Patchset #1 (id:40001) has been deleted

[pkotwicz, 2014-11-12 06:01:14]

pkotwicz@chromium.org changed reviewers:
+ kevers@chromium.org

[pkotwicz, 2014-11-12 06:01:14]

Kevin, can you please take a look? I wasn't able to figure out why
KeyboardController was listening to bounds changes of the container windows (as
opposed to the RootWindow). I believe that logic was introduced in
https://codereview.chromium.org/368323002/

I am pretty sure I can find interesting behavior if I write an app which moves
itself to a different display after a certain amount of time.

https://codereview.chromium.org/711243004/diff/60001/ui/keyboard/keyboard_con...
File ui/keyboard/keyboard_controller.cc (right):

https://codereview.chromium.org/711243004/diff/60001/ui/keyboard/keyboard_con...
ui/keyboard/keyboard_controller.cc:306: // keyboard window.
Kevin do you have any suggestions for comments here?

[kevers, 2014-11-12 14:46:02]

On 2014/11/12 06:01:14, pkotwicz wrote:
> Kevin, can you please take a look? I wasn't able to figure out why
> KeyboardController was listening to bounds changes of the container windows
(as
> opposed to the RootWindow). I believe that logic was introduced in
> https://codereview.chromium.org/368323002/
> 
> I am pretty sure I can find interesting behavior if I write an app which moves
> itself to a different display after a certain amount of time.
> 
>
https://codereview.chromium.org/711243004/diff/60001/ui/keyboard/keyboard_con...
> File ui/keyboard/keyboard_controller.cc (right):
> 
>
https://codereview.chromium.org/711243004/diff/60001/ui/keyboard/keyboard_con...
> ui/keyboard/keyboard_controller.cc:306: // keyboard window.
> Kevin do you have any suggestions for comments here?

The purpose of the change introduced in issue 368323002 is to update the
occluded bounds of a window if the window is moved or resized while the a11y VK
is locked in place.  I believe that I tried a strategy similar to what your are
proposing here.  It worked for resize, but not for window moves, which is why
we're looking for changes to the parent container.

[pkotwicz, 2014-11-12 15:52:42]

Patchset #2 (id:80001) has been deleted

[pkotwicz, 2014-11-12 15:53:16]

Kevin, can you please take another look?

[kevers, 2014-11-12 16:56:40]

lgtm

[pkotwicz, 2014-11-12 17:30:15]

pkotwicz@chromium.org changed reviewers:
+ oshima@chromium.org

[pkotwicz, 2014-11-12 17:30:16]

pkotwicz@chromium.org changed reviewers:
+ oshima@chromium.org

[pkotwicz, 2014-11-12 17:30:16]

Oshima for athena/ OWNERS

[pkotwicz, 2014-11-12 17:30:16]

Oshima for athena/ OWNERS

[oshima, 2014-11-12 18:53:57]

athena/ lgtm

[pkotwicz, 2014-11-12 19:46:32]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-11-12 19:47:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/711243004/100001

[commit-bot: I haz the power, 2014-11-12 20:51:11]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2014-11-12 20:52:07]

Patchset 2 (id:??) landed as
https://crrev.com/8f42251c2e197c8eccf58c9517d2b97921d4d083
Cr-Commit-Position: refs/heads/master@{#303888}