Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: sky/engine/core/fetch/ImageResource.cpp

Issue 711203002: Remove zoom() and effectiveZoom(). (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/fetch/ImageResource.h ('k') | sky/engine/core/frame/FrameView.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/fetch/ImageResource.cpp
diff --git a/sky/engine/core/fetch/ImageResource.cpp b/sky/engine/core/fetch/ImageResource.cpp
index b16b7598e5440a38c9a8460ec84643763f67ea68..4b3c5dbe4b576fdb2f5fd148f9b996b9d85c9881 100644
--- a/sky/engine/core/fetch/ImageResource.cpp
+++ b/sky/engine/core/fetch/ImageResource.cpp
@@ -124,7 +124,7 @@ void ImageResource::switchClientsToRevalidatedResource()
Resource::switchClientsToRevalidatedResource();
ImageResource* revalidatedImageResource = toImageResource(resourceToRevalidate());
for (ContainerSizeRequests::iterator it = switchContainerSizeRequests.begin(); it != switchContainerSizeRequests.end(); ++it)
- revalidatedImageResource->setContainerSizeForRenderer(it->key, it->value.first, it->value.second);
+ revalidatedImageResource->setContainerSizeForRenderer(it->key, it->value);
return;
}
@@ -205,14 +205,13 @@ blink::Image* ImageResource::imageForRenderer(const RenderObject* renderer)
return m_image.get();
}
-void ImageResource::setContainerSizeForRenderer(const ImageResourceClient* renderer, const IntSize& containerSize, float containerZoom)
+void ImageResource::setContainerSizeForRenderer(const ImageResourceClient* renderer, const IntSize& containerSize)
{
if (containerSize.isEmpty())
return;
ASSERT(renderer);
- ASSERT(containerZoom);
if (!m_image) {
- m_pendingContainerSizeRequests.set(renderer, SizeAndZoom(containerSize, containerZoom));
+ m_pendingContainerSizeRequests.set(renderer, containerSize);
return;
}
@@ -243,31 +242,17 @@ bool ImageResource::imageHasRelativeHeight() const
return false;
}
-LayoutSize ImageResource::imageSizeForRenderer(const RenderObject* renderer, float multiplier, SizeType sizeType)
+LayoutSize ImageResource::imageSizeForRenderer(const RenderObject* renderer, SizeType sizeType)
{
ASSERT(!isPurgeable());
if (!m_image)
return IntSize();
- LayoutSize imageSize;
-
if (m_image->isBitmapImage() && (renderer && renderer->shouldRespectImageOrientation() == RespectImageOrientation))
- imageSize = toBitmapImage(m_image.get())->sizeRespectingOrientation();
- else
- imageSize = m_image->size();
-
- if (multiplier == 1.0f)
- return imageSize;
+ return toBitmapImage(m_image.get())->sizeRespectingOrientation();
- // Don't let images that have a width/height >= 1 shrink below 1 when zoomed.
- float widthScale = m_image->hasRelativeWidth() ? 1.0f : multiplier;
- float heightScale = m_image->hasRelativeHeight() ? 1.0f : multiplier;
- LayoutSize minimumSize(imageSize.width() > 0 ? 1 : 0, imageSize.height() > 0 ? 1 : 0);
- imageSize.scale(widthScale, heightScale);
- imageSize.clampToMinimumSize(minimumSize);
- ASSERT(multiplier != 1.0f || (imageSize.width().fraction() == 0.0f && imageSize.height().fraction() == 0.0f));
- return imageSize;
+ return m_image->size();
}
void ImageResource::computeIntrinsicDimensions(Length& intrinsicWidth, Length& intrinsicHeight, FloatSize& intrinsicRatio)
@@ -309,7 +294,7 @@ inline void ImageResource::createImage()
// Send queued container size requests.
if (m_image->usesContainerSize()) {
for (ContainerSizeRequests::iterator it = m_pendingContainerSizeRequests.begin(); it != m_pendingContainerSizeRequests.end(); ++it)
- setContainerSizeForRenderer(it->key, it->value.first, it->value.second);
+ setContainerSizeForRenderer(it->key, it->value);
}
m_pendingContainerSizeRequests.clear();
}
« no previous file with comments | « sky/engine/core/fetch/ImageResource.h ('k') | sky/engine/core/frame/FrameView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698