Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 711203002: Remove zoom() and effectiveZoom(). (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove zoom() and effectiveZoom(). No change in behavior since we already removed the zoom setters. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/216133d170fa48178bd444c9b106566a01420caa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -353 lines) Patch
M sky/engine/core/animation/KeyframeEffectModelTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/animation/animatable/AnimatableLength.h View 2 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/animation/animatable/AnimatableLength.cpp View 1 chunk +5 lines, -6 lines 0 comments Download
M sky/engine/core/animation/animatable/AnimatableLengthTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/animation/css/CSSAnimatableValueFactory.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSGradientValue.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/CSSMatrix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/CSSPrimitiveValue.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/css/CSSPrimitiveValue.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M sky/engine/core/css/CSSToLengthConversionData.h View 2 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/css/CSSToLengthConversionData.cpp View 1 chunk +0 lines, -32 lines 0 comments Download
M sky/engine/core/css/CSSValuePool.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/CSSValuePool.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/FontSize.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/FontSize.cpp View 2 chunks +6 lines, -7 lines 0 comments Download
M sky/engine/core/css/resolver/AnimatedStyleBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/css/resolver/FilterOperationResolver.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/css/resolver/FontBuilder.h View 3 chunks +4 lines, -6 lines 0 comments Download
M sky/engine/core/css/resolver/FontBuilder.cpp View 8 chunks +12 lines, -18 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderConverter.h View 1 chunk +1 line, -7 lines 0 comments Download
M sky/engine/core/css/resolver/StyleBuilderCustom.cpp View 4 chunks +7 lines, -13 lines 0 comments Download
M sky/engine/core/css/resolver/StyleResolver.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M sky/engine/core/css/resolver/TransformBuilder.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M sky/engine/core/dom/Element.cpp View 4 chunks +4 lines, -35 lines 0 comments Download
M sky/engine/core/fetch/ImageResource.h View 3 chunks +4 lines, -6 lines 0 comments Download
M sky/engine/core/fetch/ImageResource.cpp View 4 chunks +7 lines, -22 lines 0 comments Download
M sky/engine/core/frame/FrameView.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/frame/FrameView.cpp View 3 chunks +1 line, -15 lines 0 comments Download
M sky/engine/core/html/HTMLImageElement.cpp View 6 chunks +6 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/FilterEffectRenderer.cpp View 3 chunks +4 lines, -14 lines 0 comments Download
M sky/engine/core/rendering/InlineFlowBox.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 4 chunks +3 lines, -16 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.h View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 7 chunks +7 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/RenderHTMLCanvas.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderImage.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderImageResource.h View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderImageResource.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderImageResourceStyleImage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderImageResourceStyleImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 4 chunks +3 lines, -14 lines 0 comments Download
M sky/engine/core/rendering/RenderReplaced.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyle.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/style/StyleFetchedImage.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/StyleFetchedImage.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/style/StyleFetchedImageSet.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/StyleFetchedImageSet.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/style/StyleGeneratedImage.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/style/StyleGeneratedImage.cpp View 1 chunk +4 lines, -20 lines 0 comments Download
M sky/engine/core/rendering/style/StyleImage.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/StylePendingImage.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
esprehn
lgtm
6 years, 1 month ago (2014-11-11 00:44:21 UTC) #2
ojan
6 years, 1 month ago (2014-11-11 01:32:57 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
216133d170fa48178bd444c9b106566a01420caa.

Powered by Google App Engine
This is Rietveld 408576698